fix(a11y): add main landmark, unique nav labels, and fix color contrast#7894
Closed
Rishabh037 wants to merge 3 commits intowebpack:mainfrom
Closed
fix(a11y): add main landmark, unique nav labels, and fix color contrast#7894Rishabh037 wants to merge 3 commits intowebpack:mainfrom
Rishabh037 wants to merge 3 commits intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| "prettier": "^3.8.1", | ||
| "react-refresh": "^0.18.0", | ||
| "react-test-renderer": "^17.0.2", | ||
| "react-test-renderer": "17.0.2", |
| <Route path="*" element={<PageNotFound />} /> | ||
| </Route> | ||
| </Routes> | ||
| </main> |
Member
There was a problem hiding this comment.
We already have the main, it is not a good to have multiple mains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(a11y): improve footer link accessibility (WCAG 2.1 AA compliance)
Summary
This PR resolves accessibility issues reported by axe DevTools on the documentation homepage related to footer links.
The affected links relied primarily on color for distinction and did not fully meet WCAG 2.1 AA requirements for link accessibility and contrast.
Problem
Accessibility scans reported:
This can impact:
Changes Made
text-decoration: underlineto footer paragraph linksBefore / After
🔴 Before
🟢 After