feat(banner): show latest webpack release instead of Node.js banner#151
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
I'd rather have this file be manually updated, since there are times where the banner may need to say other things
|
okay dropping the script for banner , instead can we just add into /assets/banner.json ? that can be customised as per need |
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
Could we make it so that it can be configured manually, and if no manual configuration exists, it automatically shows the latest blog post, with the banner being displayed for one month when it's in automatic mode?
The fewer manual tasks, the better. For example, I had to add something like this to the Express website because we always forget to update the banner. I don't know if that would happen here as well, but if we can avoid forgetting to update it, that would be even better
|
I think that can be done in a workflow to automate release blog posts, I know you said there's a lot of manual work involved, but the "draft" PR could have a basic release post + a banner set up? |
|
Sorry , I pushed the fixup without reading the comments , I missed it |
|
I think this is a good PR as is. Future automations can be follow-ups, right? |
|
yes ! @bjohansebas idea regarding is also right if no manual edits we can show automatically the new blogs , and so yes we can keep it in upcoming PRs ! |
3 participants
Fixes : #143
Summary
Bugfix + feature :- fixes the Node.js banner leaking in and shows a webpack release banner instead.
What kind of change does this PR introduce?
Feat
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?
NA
Use of AI
for regex