Skip to content

fix(blog): rely on the source of data instead the props#150

Merged
avivkeller merged 1 commit into
webpack:mainfrom
moshams272:fix/authors-byline
Jun 20, 2026
Merged

fix(blog): rely on the source of data instead the props#150
avivkeller merged 1 commit into
webpack:mainfrom
moshams272:fix/authors-byline

Conversation

@moshams272

@moshams272 moshams272 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

As we rely on the string way in authors in metadata instead of array way, the Byline component didn't appear.
So, instead of using metadata, we use the source of truth the JSON posts that has the authors as array that the Byline needs.

Before:

image

After:

image

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jun 20, 2026 12:45pm

Request Review

@avivkeller

Copy link
Copy Markdown
Member

Nice catch! Whoops on my part 😅

@avivkeller avivkeller merged commit 61b7809 into webpack:main Jun 20, 2026
5 checks passed
@moshams272

Copy link
Copy Markdown
Contributor Author

Learning from you 🤍

@moshams272 moshams272 deleted the fix/authors-byline branch June 20, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants