Skip to content

Conversation

@grossmannmartin
Copy link

Description

This reverts commit that was merged in #1805.

Reason for Revert

PR #1805 introduced a breaking change in a minor version by removing public API methods from SyncPromise:

  • SyncPromise::runQueue() - removed
  • SyncPromise::getQueue() - removed

These methods were replaced by a new SyncPromiseQueue class, but the original public methods were not preserved for backward compatibility.

Impact

The runQueue() method is used by external libraries, notably https://github.com/overblog/dataloader-php, in their WebonyxGraphQLSyncPromiseAdapter

After upgrading to v15.29.0, any code relying on these public methods fails.

Recommendation

The memory optimization from #1805 is valuable and should be re-introduced, but with proper backward compatibility:

  1. Keep SyncPromise::runQueue() and SyncPromise::getQueue() as deprecated wrappers
  2. Add deprecation notices pointing to SyncPromiseQueue
  3. Remove the deprecated methods in the next major version (v16.0.0)

Related

@spawnia
Copy link
Collaborator

spawnia commented Dec 19, 2025

We can discuss a resolution for the issue you are seeing in #1820, I do not plan to revert though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants