Revert "Optimize Deferred execution (#1805)"
#1821
Closed
+214
−655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit that was merged in #1805.
Reason for Revert
PR #1805 introduced a breaking change in a minor version by removing public API methods from SyncPromise:
These methods were replaced by a new SyncPromiseQueue class, but the original public methods were not preserved for backward compatibility.
Impact
The runQueue() method is used by external libraries, notably https://github.com/overblog/dataloader-php, in their WebonyxGraphQLSyncPromiseAdapter
After upgrading to v15.29.0, any code relying on these public methods fails.
Recommendation
The memory optimization from #1805 is valuable and should be re-introduced, but with proper backward compatibility:
Related
Deferredexecution #1805