feat: Refactor Rendition to use DOM adapter #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstracts all DOM operations in the Rendition class behind a `DOMAdapter` protocol. This decouples the class from the Pyodide environment, allowing for easier testing and improved modularity. - Creates a `DOMAdapter` protocol and `PyodideDOMAdapter` implementation. - Refactors `Rendition` to accept a `DOMAdapter` via dependency injection. - Introduces a `MockDOMAdapter` for use in unit tests. - Updates all relevant tests to use the new mock adapter, removing the need for `sys.modules` patching.
Abstracts all DOM operations in the Rendition class behind a `DOMAdapter` protocol. This decouples the class from the Pyodide environment, allowing for easier testing and improved modularity. - Creates a `DOMAdapter` protocol and `PyodideDOMAdapter` implementation. - Refactors `Rendition` to accept a `DOMAdapter` via dependency injection. - Introduces a `MockDOMAdapter` for use in unit tests. - Updates all relevant tests to use the new mock adapter, removing the need for `sys.modules` patching.
Abstracts all DOM operations in the Rendition class behind a `DOMAdapter` protocol. This decouples the class from the Pyodide environment, allowing for easier testing and improved modularity. - Creates a `DOMAdapter` protocol and `PyodideDOMAdapter` implementation. - Refactors `Rendition` to accept a `DOMAdapter` via dependency injection. - Introduces a `MockDOMAdapter` for use in unit tests. - Updates all relevant tests to use the new mock adapter, removing the need for `sys.modules` patching.
webmaven
deleted the
feature-issue-14-refactor-rendition-8139800673545755144
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracts all DOM operations in the Rendition class behind a
DOMAdapterprotocol. This decouples the class from the Pyodide environment, allowing for easier testing and improved modularity.DOMAdapterprotocol andPyodideDOMAdapterimplementation.Renditionto accept aDOMAdaptervia dependency injection.MockDOMAdapterfor use in unit tests.sys.modulespatching.Closes #14.