Validate output channels are a multiple of groups in conv2d#932
Open
lynne0326 wants to merge 1 commit intowebmachinelearning:mainfrom
Open
Validate output channels are a multiple of groups in conv2d#932lynne0326 wants to merge 1 commit intowebmachinelearning:mainfrom
lynne0326 wants to merge 1 commit intowebmachinelearning:mainfrom
Conversation
huningxin
reviewed
May 4, 2026
| :: Let « |outputChannels|, |filterInputChannels|, |filterHeight|, |filterWidth| » be |filterShape|. | ||
| </dl> | ||
| 1. If |inputChannels| % |options|.{{MLConv2dOptions/groups}} is not 0, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If |outputChannels| % |options|.{{MLConv2dOptions/groups}} is not 0, then [=exception/throw=] a {{TypeError}}. |
Contributor
There was a problem hiding this comment.
Consider moving the new check to after the "Otherwise, if |inputChannels| / |options|.{{MLConv2dOptions/groups}} is not equal to |filterInputChannels|" step? This keeps the related inputChannels checks grouped together and avoids breaking the if/otherwise prose flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #925.
Preview | Diff