fix(host-targets): classify CYGWIN and MINGW as windows, not linux#23
Merged
Conversation
Cygwin (CYGWIN_NT-*) and Git Bash (MINGW64_NT-*) run on Windows and need Windows binaries. The previous linux classification caused webi.sh to serve Linux ELF binaries (e.g. gh_linux_amd64.tar.gz) which cannot run on Windows hosts. Also add 'gnu' and 'libc' libc fallbacks to the Windows WATERFALL so that Cygwin/MINGW hosts (which report 'gnu' or 'libc' as their libc) can reach msvc-tagged and static Windows packages. Adds host-targets-test.js with explicit os/arch/vendor assertions for all known Cygwin and MINGW user-agent patterns, including the Windows 11 build from issue #1083. Bumps to v1.0.4.
ANYOS already provides ['none', 'gnu'] for gnu hosts and the extended
['none', 'gnu', 'musl', 'libc'] for libc hosts, which reaches static
('none') Windows packages. Explicit msvc preference was also wrong
since msvc requires vcredist — 'none' is always preferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CYGWIN_NT-*) and Git Bash/MINGW (MINGW64_NT-*) run on Windows and need Windows binaries. The previousT.LINUXclassification caused webi.sh to serve Linux ELF binaries (e.g.gh_linux_amd64.tar.gz) which cannot run on Windows hosts.CYGWIN: T.LINUX→CYGWIN: T.WINDOWSandMINGW: T.LINUX→MINGW: T.WINDOWS.gnuandlibclibc fallbacks to the Windows WATERFALL so Cygwin/MINGW hosts (which reportgnuorlibcas their libc) can reachmsvc-tagged and static (none) Windows packages.host-targets-test.jswith explicitos/arch/vendorassertions for all known Cygwin and MINGW user-agent patterns, including the Windows 11 build from webi-installers#1083.Test plan
npm test— bothlexver-test.jsandhost-targets-test.jspassnode lint-host-targets.js— no new errors for CYGWIN/MINGW entries