Skip to content

fix(maybeInstallable): match TERMS_EXTS_NON_BUILD against filename, not URL #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coolaj86 merged 1 commit into from
May 7, 2026
Merged

fix(maybeInstallable): match TERMS_EXTS_NON_BUILD against filename, not URL #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions triplet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,14 +456,21 @@ var Triplet = ('object' === typeof module && exports) || {};
}
}

// Check the filename, not the full URL. Some download URLs are API
// endpoints whose path tail looks like an extension match — e.g.
// `.../tarball/v1.0.1` ends with `.1` (a TERMS_EXTS_NON_BUILD entry
// intended for `manpage.1`), causing maybeInstallable to falsely
// reject any package version ending in `.1`. The filename itself is
// the canonical source for extension classification.
let filename = build.name || build.download;
for (let ext of Triplet.TERMS_EXTS_NON_BUILD) {
if (build.download.endsWith(ext)) {
if (filename.endsWith(ext)) {
return false;
}
}

for (let re of Triplet._RE_TERMS_NON_BUILD) {
if (re.test(build.download)) {
if (re.test(filename)) {
return false;
}
}
Expand Down
Loading