[breaking] Remove return value from wgpuInstanceGetWGSLLanguageFeatures#554
Merged
kainino0x merged 1 commit intoJul 11, 2025
Merged
Conversation
This method has no error conditions, so it should return void like wgpuAdapter/DeviceGetFeatures and wgpuGetInstanceFeatures.
lokokung
approved these changes
Jul 11, 2025
Collaborator
Author
|
I don't think this will affect anyone other than Dawn but feel free if you have any comments @cwfitzgerald |
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jul 12, 2025
This method just returns an array, it doesn't take an extensible struct. So it's infallible like wgpuAdapter/DeviceGetFeatures and wgpuGetInstanceFeatures and should return void. Corresponding upstream PR: webgpu-native/webgpu-headers#554 Fixed: 429178774 Change-Id: Ibf21e2db11a1172be8a8d9271db3c6a282f0bc00 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/252256 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Loko Kung <lokokung@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method has no error conditions, so it should return void like wgpuAdapter/DeviceGetFeatures and wgpuGetInstanceFeatures.