[breaking] Add new texture formats from texture-formats-tier1#553
Merged
kainino0x merged 1 commit intoJul 7, 2025
Merged
Conversation
Add the new texture formats from texture-formats-tier1 (16 bits per channel unorm/snorm). Maintain the same ordering as in the JS API. This changes the ABI by changing enum values.
kainino0x
approved these changes
Jul 7, 2025
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
lgtm, thank you!
BTW, I think we should stop changing enum values about now - for the FeatureName I mostly did it so compat would be first, but it's also nice for these to be in a less confusing order. Since it probably shouldn't affect anyone in practice I say let's go ahead with this.
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jul 12, 2025
Also updates TextureUtils.cpp, including accounting for TextureFormatsTier1 on both Dawn and Emscripten, and fixing a bug that mixed up Snorm16 formats with wgpu::FeatureName::Unorm16TextureFormats. Upstream WGPUTextureFormat change: webgpu-native/webgpu-headers#553 Roll also eliminates the diff on wgpuInstanceGetWGSLLanguageFeatures. Bug: 429178774, 427657664, 421941589 Change-Id: I4a3e88ab8a902d9087d69b3f36a32f8a685a60c2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/252260 Reviewed-by: Loko Kung <lokokung@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new texture formats from texture-formats-tier1 (16 bits per channel unorm/snorm). Maintain the same ordering as in the JS API. This changes the ABI by changing enum values.