Rename WGPUInstanceFeatureName_TimedWaitAnyEnable -> TimedWaitAny#549
Merged
Conversation
`WGPUInstanceFeature_TimedWaitAnyEnable` (formerly `WGPUInstanceCapabilities.timedWaitAnyEnable`) should be called simply `TimedWaitAny` now that it's a feature name. Aside, it's arguably redundant with `timedWaitAnyMaxCount`. It would be simpler to use if we didn't have a feature, and just set `timedWaitAnyMaxCount` to 0 or not. The reason this wasn't the case originally is because it has a minimum value of 64, so if we did this then 0 -> disabled at 0, 1 -> enabled at 64, which is slightly odd. I'm inclined not to bother to change this.
lokokung
approved these changes
Jun 18, 2025
Collaborator
Author
|
(Going ahead with landing now, but feel free to comment later and I'll follow up) |
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jun 27, 2025
Per upstream changes: - webgpu-native/webgpu-headers#533 - webgpu-native/webgpu-headers#549 Fixed: 414868137 Change-Id: I3c4603738210d6180d930594f4b49259b41a4730 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/245242 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WGPUInstanceFeature_TimedWaitAnyEnable(formerlyWGPUInstanceCapabilities.timedWaitAnyEnable) should be called simplyTimedWaitAnynow that it's a feature name.Aside, it's arguably redundant with
timedWaitAnyMaxCount. It would be simpler to use if we didn't have a feature, and just settimedWaitAnyMaxCountto 0 or not. The reason this wasn't the case originally is because it has a minimum value of 64, so if we did this then:which is slightly odd. I'm inclined not to bother to change this.