Skip to content

Document the buffer usage enum#538

Merged
kainino0x merged 2 commits into
webgpu-native:mainfrom
eliemichel:eliemichel/buffer-map-doc
May 1, 2025
Merged

Document the buffer usage enum#538
kainino0x merged 2 commits into
webgpu-native:mainfrom
eliemichel:eliemichel/buffer-map-doc

Conversation

@eliemichel
Copy link
Copy Markdown
Collaborator

@eliemichel eliemichel commented May 1, 2025

In particular this addresses #537 if mappedAtCreation indeed does not require MapWrite usage.

@eliemichel eliemichel added buffer mapping MapAsync and friends non-breaking Does not require a breaking change (that would block V1.0) labels May 1, 2025
kainino0x
kainino0x approved these changes May 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't prioritize documenting any of this since it's the same as the JS API (and we have #473), but regardless LGTM!

@kainino0x kainino0x enabled auto-merge (squash) May 1, 2025 20:41
@kainino0x kainino0x merged commit a9b10b5 into webgpu-native:main May 1, 2025
5 checks passed
@eliemichel eliemichel deleted the eliemichel/buffer-map-doc branch May 1, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

@lokokung lokokung lokokung approved these changes

Assignees

No one assigned

Labels

buffer mapping MapAsync and friends non-breaking Does not require a breaking change (that would block V1.0)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliemichel @kainino0x @lokokung