[breaking] Refactor Instance capabilities into features/limits, add SPIRV feature#533
Merged
Merged
Conversation
kainino0x
added
post-RC breaking change
kainino0x
force-pushed
the
instance-features-limits
branch
2 times, most recently
from
b33fdc9 to
aecc0b2
Compare
- I did NOT rename WGPUFeatureName, WGPUSupportedFeatures, and WGPULimits because they're used for both Adapter and Device, so picking one could be confusing. - WGPUWGSLLanguageFeatureName could be flattened into WGPUInstanceFeatureName.
kainino0x
force-pushed
the
instance-features-limits
branch
from
aecc0b2 to
1a3b312
Compare
Kangz
approved these changes
Apr 25, 2025
lokokung
approved these changes
Apr 25, 2025
Collaborator
Author
@cwfitzgerald given this, how strongly do you feel about renaming them, and how would you name them? |
kainino0x
changed the title
kainino0x
added
!discuss
Collaborator
Author
|
May 1 meeting:
|
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jun 27, 2025
Per upstream changes: - webgpu-native/webgpu-headers#533 - webgpu-native/webgpu-headers#549 Fixed: 414868137 Change-Id: I3c4603738210d6180d930594f4b49259b41a4730 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/245242 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WGPUWGSLLanguageFeatureNamecould be flattened intoWGPUInstanceFeatureName(EDIT: but they're different because they're not disableable, so these would be "auto-enabled"). I haven't done this here.Issue #522 (dawn bug https://crbug.com/414868137)