Emit correct exit code on Sass compilation errors if env != development#19
Open
polarbirke wants to merge 2 commits intomasterfrom
Open
Emit correct exit code on Sass compilation errors if env != development#19polarbirke wants to merge 2 commits intomasterfrom
polarbirke wants to merge 2 commits intomasterfrom
Conversation
Use hard exit for prod, staging and testing environments (this is especially important for CI debugging) when Sass encounters compilation errors. On the other hand, it is useful to only emit "soft" errors during local development; it would be frustrating if watch/serve process would crash every time a Sass compilation is not successful (e.g. because of a typo).
Member
|
Failing hard in environments other than development is definitely an improvement compared to failing soft everywhere. However, I'm wondering if there is a better way to allow soft errors for background tasks (watch/serve) while keeping the hard errors for build tasks? I don't use watch/serve regularly and I would appreciate it if a build process ( Can you see in gulp whether it's running in a watch/serve process? Could you start the watch/serve with a parameter to suppress hard errors? |
Member
Author
|
Super Idee @sebastiankugler 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use hard exit for prod, staging and testing environments (this
is especially important for CI debugging) when Sass encounters
compilation errors. On the other hand, it is useful to only emit
"soft" errors during local development; it would be frustrating
if watch/serve process would crash every time a Sass compilation
is not successful (e.g. because of a typo).