Conversation
The variable contains more or less the opposite information than what it says: It operates on the level of the versions that are already present and tells if the version is also present in the imported ones (and therefore, going to stay after the set).
When the matching version is found, there is no need to continue the loop
When reassigning collections of objects in Doctrine entities, this can create problems with unique constraints if the new collection contains objects with data already present to the old one, but the object does not share the same reference in memory. In this case, Doctrine tries to add the new objects first when saving the collection, leading to duplicate entries in the database. We see issues that look exactly like this in our production log, and this assignment looks exactly like the one causing the problem. But I couldn't reproduce the issue, so I couldn't test if this fixes it. I'm still going to roll it out – if it doesn't fix the issue (or introduces new ones), we will see this in our logs.
janopae
changed the title
janopae
changed the title
janopae
deleted the
205891_Fehler-bei-Request-aW-wCb23YEEEHQzfxC3_9wAAABM
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reassigning collections of objects in Doctrine entities, this can create problems with unique constraints if the new collection contains objects with data already present to the old one, but the object does not share the same reference in memory. In this case, Doctrine tries to add the new objects first when saving the collection, leading to duplicate entries in the database.
We see issues that look exactly like this in our production log on a regular basis, and this assignment looks exactly like the one causing the problem. But I couldn't reproduce the issue, so I couldn't test if this fixes it.
I'm still going to roll it out – if it doesn't fix the issue (or introduces new ones), we will see this in our logs.