0.0.9-alpha by ReneSchwarzer · Pull Request #9 · webexpress-framework/WebExpress.WebCore

ReneSchwarzer · 2025-10-29T17:21:42Z

This pull request introduces several improvements and updates to the project infrastructure, documentation, and test utilities. The most significant changes include the addition of a new GitHub Actions workflow for running unit tests, updates to documentation links and branding to reflect the new organization, enhancements to the build and documentation generation pipeline, and improvements to test fixtures and assertion utilities.

CI/CD and Build Pipeline Updates:

Added a new GitHub Actions workflow (.github/workflows/test.yml) to automatically build the project and run xUnit unit tests on pull requests and manual triggers. This ensures code quality and stability through automated testing.
Enhanced the documentation generation workflow (.github/workflows/generate-docs.yml) by building WebExpress.WebCore, preparing the wwwroot directory, and generating an API toc.yaml for improved navigation in API docs. Also fixed the artifact upload path.

Documentation and Branding Updates:

Updated all documentation and README links, as well as banner image URLs, to point to the new webexpress-framework organization instead of the previous user repository. This ensures consistency and proper attribution across the project. [1] [2] [3] [4] [5] [6] [7] [8]
Changed the API documentation output path in docs/docfx.json for improved compatibility with the new build pipeline.
Updated the table of contents in docs/toc.yml to link directly to the API documentation folder, improving navigation.

Test Infrastructure and Utilities:

Added a new assertion utility AssertExtensions in src/WebExpress.WebCore.Test/Fixture/AssertExtensions.cs to facilitate flexible string comparison in tests, supporting placeholders and whitespace normalization.
Improved test fixture setup in UnitTestFixture.cs by making the mock server context and component hub creation more robust and flexible. [1] [2]
Added a sample CSS file for styling test output in src/WebExpress.WebCore.Test/Assets/css/my-css.css.

API and Identity Model Adjustments:

Updated the mock identity group and factory to use "Policies" instead of "Roles" for group assignments, reflecting a shift in terminology and structure in the test data model. [1] [2]

License Update:

Updated the copyright year in the LICENSE file to 2025.

- now registers each individual asset instead of just the base path

Copilot

Pull Request Overview

This is a major refactoring and feature addition PR for the WebExpress.WebCore framework, bumping the version from 0.0.8.0 to 0.0.9.0. The changes introduce significant improvements to REST API handling, identity management terminology updates, new validation infrastructure, and various architectural enhancements.

Key Changes:

Introduced comprehensive REST API validation infrastructure with fluent API support (RestApiValidator, RestApiValidationResult, RestApiError)
Renamed "Role" to "Policy" throughout the identity management system for clearer terminology
Added new response types (ResponseNoContent, ResponseUnprocessableEntity, ResponseCreated, ResponseMovedTemporarily, ResponseMovedPermanently) and removed deprecated redirect responses
Introduced IIncludeManager for managing JavaScript and CSS client resources per application
Refactored context path references to "Route" for consistency
Enhanced HTML element manipulation with fluent APIs and improved CSS handling
Added session cleanup functionality with configurable timeout

Reviewed Changes

Copilot reviewed 165 out of 165 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
WebExpress.WebCore.csproj	Version bump to 0.0.9.0, repository URL updates, configuration changes
WebUri/UriEndpoint.cs, IUri.cs	Added `SetFragment` method for URI fragment manipulation
WebUri/UriAuthority.cs	Fixed typo: "adress" → "address"
WebRestApi/*.cs	New validation infrastructure with fluent API for request validation
WebMessage/*.cs	New response types, content type enum, BadRequestException
WebIdentity/*.cs	Renamed "Role" to "Policy" across identity management
WebInclude/*.cs	New include manager for client-side JavaScript/CSS resources
WebHtml/*.cs	Enhanced HTML element APIs with fluent methods, CSS utilities
WebSession/*.cs	Added session cleanup method with timeout support
WebStatusPage/*.cs	Added description field support
WebTask/*.cs	Generic type parameter renamed from `T` to `TTask`, task removal delayed
WebPackage/*.cs	Enhanced package change detection, improved extraction logic
HttpServer.cs, WebEx.cs	Added events for initialization/start/exit, improved error handling
ApplicationContext.cs	Renamed `ContextPath` to `Route`

Comments suppressed due to low confidence (9)

src/WebExpress.WebCore/WebIdentity/IdentityManager.cs:217

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.
src/WebExpress.WebCore/WebIdentity/IdentityManager.cs:480
This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.
src/WebExpress.WebCore/WebPackage/PackageManager.cs:466
Variable package may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:355
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:227
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:277
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:288
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:333
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:344
Variable this._httpServerContext may be null at this access as suggested by this null check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T17:31:13Z

src/WebExpress.WebCore/WebUri/UriEndpoint.cs

+        /// <summary>
+        /// Sets the fragment component of the URI.
+        /// </summary>
+        /// <returns>A new IUri instance with the updated fragment. The original URI remains unchanged.</returns>
+        public IUri SetFragment(string fragment)
+        {
+            return new UriEndpoint(Scheme, Authority, fragment, Query, PathSegments);
+        }


The SetFragment method documentation is missing a parameter description for the fragment parameter. Add <param name=\"fragment\">The fragment value to set in the URI.</param> to complete the documentation.

Copilot · 2025-10-29T17:31:14Z

src/WebExpress.WebCore/WebTask/TaskManager.cs

        /// <param name="id">The id of the task.</param>
        /// <param name="handler">The event handler.</param>
        /// <param name="args">The event argument.</param>
+        /// <typeparam name="TTask">The type of the task.</typeparam>-


Remove the trailing hyphen at the end of the XML documentation comment.

Copilot · 2025-10-29T17:31:14Z

src/WebExpress.WebCore/WebRestApi/RestApiValidationResult.cs

+        /// This method appends the specified errors to the existing collection. If 
+        /// the array isempty, no changes are made.


Corrected spelling of 'isempty' to 'is empty'.

Copilot · 2025-10-29T17:31:14Z

src/WebExpress.WebCore/WebRestApi/RestApiValidationResult.cs

+        /// This method appends the specified errors to the existing collection. If 
+        /// the array isempty, no changes are made.


Corrected spelling of 'isempty' to 'is empty'.

Copilot · 2025-10-29T17:31:15Z

src/WebExpress.WebCore/WebRestApi/RestApiValidator.cs

+        /// A function that evaluates the request and returns true" if the 
+        /// condition is met; otherwise,false.


Remove the extra quotation mark after 'true' and add a space before 'false'.

Copilot · 2025-10-29T17:31:29Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                    catch (Exception)
+                    {
+                        // ignore errors while enumerating plugin output files
+                        continue;
+                    }


Generic catch clause.

Copilot · 2025-10-29T17:31:29Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                            catch
+                            {
+                                // fallback to file name if relative path fails
+                                relativePath = Path.GetFileName(fileName);
+                            }


Generic catch clause.

Copilot · 2025-10-29T17:31:29Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                catch (Exception)
+                {
+                    // ignore errors while enumerating and continue with parent
+                }


Generic catch clause.

Copilot · 2025-10-29T17:31:30Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                catch
+                {
+                    path = null;
+                }


Generic catch clause.

Copilot · 2025-10-29T17:31:30Z

src/WebExpress.WebCore/WebPackage/PackageManager.cs

+            catch (Exception ex)
+            {
+                // keep running even if cleanup fails
+                _httpServerContext.Log.Exception(ex);
+            }


Generic catch clause.

Copilot

Pull Request Overview

Copilot reviewed 165 out of 165 changed files in this pull request and generated 19 comments.

Comments suppressed due to low confidence (8)

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs:1

In HtmlElementMetadataBase.cs, the Href setter now uses TrimEnd() which removes all trailing whitespace. The original code had logic to ensure a trailing slash was added if missing, but the new implementation removes this entirely. This appears to be incorrect as the variable name url suggests it should still be a valid URL, and the comment about ensuring trailing slash suggests this was intentional behavior that has been lost.
src/WebExpress.WebCore/WebPackage/PackageManager.cs:466
Variable package may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:355
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:227
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:277
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:288
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:333
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:344
Variable this._httpServerContext may be null at this access as suggested by this null check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T18:13:30Z

src/WebExpress.WebCore/WebUri/UriEndpoint.cs

+        /// <returns>A new IUri instance with the updated fragment. The original URI remains unchanged.</returns>
+        public IUri SetFragment(string fragment)
+        {
+            return new UriEndpoint(Scheme, Authority, fragment, Query, PathSegments);


The SetFragment method appears to be passing parameters in the wrong order. Based on the UriEndpoint constructor signature visible elsewhere in the codebase, the fragment parameter should typically come after Query, not before it. The correct order should likely be: new UriEndpoint(Scheme, Authority, PathSegments, Query, fragment) or similar, depending on the actual constructor signature.

Copilot · 2025-10-30T18:13:31Z

src/WebExpress.WebCore/WebTask/Task.cs

+                System.Threading.Tasks.Task.Delay(30000).ContinueWith(_ =>
+                {
+                    WebEx.ComponentHub.TaskManager.RemoveTask(this);
+                });


The task removal is now delayed by 30 seconds without awaiting the continuation. This could lead to a race condition where the task is accessed after it should have been removed but before the 30-second delay completes. Additionally, if the task is cancelled or the application shuts down, the continuation may still execute. Consider using CancellationToken or ensuring proper cleanup.

Copilot · 2025-10-30T18:13:31Z

src/WebExpress.WebCore/WebHtml/HtmlElement.cs

+            else if (ContainsOnlyTextNodes(_elements, out var text))
+            {
+                closeTag = CloseTag;
+                nl = false;
+
+                builder.Append(text);
+            }


The logic at line 422 sets closeTag = CloseTag, but this appears redundant since closeTag is a local boolean that's only used to determine whether to call ToPostString. The original code set closeTag = true for text-only content. Setting it to the property value CloseTag may not produce the intended behavior for self-closing elements.

Copilot · 2025-10-30T18:13:31Z

src/WebExpress.WebCore/WebIdentity/IdentityManager.cs

+                foreach (var customAttribute in permissionType.CustomAttributes
+                    .Where(x => x.AttributeType.GetInterfaces().Contains(typeof(IPolicyAttribute))))
+                {
+                    if
+                    (
+                        customAttribute.AttributeType.Name == typeof(PolicyAttribute<>).Name &&
+                        customAttribute.AttributeType.Namespace == typeof(PolicyAttribute<>).Namespace)
+                    {
+                        var type = customAttribute.AttributeType.GenericTypeArguments.FirstOrDefault();
+                        if (type != null && !policyTypes.Contains(type))
+                        {
+                            policyTypes.Add(type);
+                        }
+                    }
+                }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2025-10-30T18:13:32Z

src/WebExpress.WebCore/WebIdentity/IdentityManager.cs

+                foreach (var customAttribute in policyType.CustomAttributes
+                    .Where(x => x.AttributeType.GetInterfaces().Contains(typeof(IPermissionAttribute))))
+                {
+                    if (customAttribute.AttributeType.Name == typeof(PermissionAttribute<>).Name && customAttribute.AttributeType.Namespace == typeof(PermissionAttribute<>).Namespace)
+                    {
+                        var type = customAttribute.AttributeType.GenericTypeArguments.FirstOrDefault();
+                        if (type != null && !permissionTypes.Contains(type))
+                        {
+                            permissionTypes.Add(type);
+                        }
+                    }
+                }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2025-10-30T18:13:34Z

src/WebExpress.WebCore/WebIdentity/IdentityManager.cs

+            // permissions
+            foreach (var permissionType in assembly.GetTypes().Where
+                (
+                    x => x.IsClass == true &&


The expression 'A == true' can be simplified to 'A'.

Copilot · 2025-10-30T18:13:34Z

src/WebExpress.WebCore/WebIdentity/IdentityManager.cs

+            // policies
+            foreach (var policyType in assembly.GetTypes().Where
+                (
+                    x => x.IsClass == true &&


The expression 'A == true' can be simplified to 'A'.

Copilot · 2025-10-30T18:13:35Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                        catch
+                        {
+                            // fallback to file name if relative path fails
+                            relativePath = Path.GetFileName(fileName);
                        }


Generic catch clause.

Copilot · 2025-10-30T18:13:35Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                catch (Exception)
+                {
+                    // ignore errors while enumerating and continue with parent
+                }


Generic catch clause.

Copilot · 2025-10-30T18:13:35Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                catch
+                {
+                    path = null;
+                }


Generic catch clause.

Copilot

Pull Request Overview

Copilot reviewed 165 out of 165 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (8)

src/WebExpress.WebCore/WebTask/Task.cs:105

Disposable 'CancellationTokenSource' is created but not disposed.
src/WebExpress.WebCore/WebPackage/PackageManager.cs:466
Variable package may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:355
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:227
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:277
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:288
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:333
Variable this._httpServerContext may be null at this access as suggested by this null check.
src/WebExpress.WebCore/WebPlugin/PluginManager.cs:344
Variable this._httpServerContext may be null at this access as suggested by this null check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T19:36:15Z

src/WebExpress.WebCore/WebHtml/IHtmlElement.cs

+        IHtmlElement Add(params IHtmlAttribute[] attributes);
+
+        /// <summary>
+        /// Clear all elements frrom the html element.


Corrected spelling of 'frrom' to 'from'.

Copilot · 2025-10-30T19:36:15Z

src/WebExpress.WebCore/WebPackage/PackageBuilder.cs

+                {
+                    var matches = Directory
+                        .GetFiles(path, "*.*", SearchOption.AllDirectories)
+                        .Where(x => x.Replace('\\', '/').EndsWith(normalizedTail, StringComparison.OrdinalIgnoreCase));


The string replace operation x.Replace('\\', '/') is performed for every file in the directory during the filter operation. Consider performing the replace once on the normalized tail before the Where clause, or caching the normalized file paths to avoid repeated string allocations during enumeration.

Copilot · 2025-10-30T19:36:16Z

src/WebExpress.WebCore/WebIdentity/IdentityManager.cs

+        /// <returns>True if any group grants the permission, false otherwise.</returns>
+        public bool CheckAccess(IApplicationContext applicationContext, IIdentity identity, Type permission)
+        {
+            return (identity?.Groups ?? []).Any(group => CheckAccess(applicationContext, group, permission));


[nitpick] Using LINQ's Any with a lambda for recursive checking is more concise, but the foreach loop in the original code was clearer for debugging. If the permission check fails, it will be harder to determine which group was being evaluated. Consider keeping the foreach pattern for better debuggability.

Copilot · 2025-10-30T19:36:16Z

src/WebExpress.WebCore.Test/Manager/UnitTestPackageManager.cs

+            var httpServerContext = UnitTestFixture.CreateHttpServerContextMock();
+            var componentHub = UnitTestFixture.CreateComponentHubMock(httpServerContext);
+            var packageManager = componentHub.PackageManager as PackageManager;
+            var packagePath = httpServerContext.PackagePath;


Call to 'System.IO.Path.Combine'.

Suggested change

var packagePath = httpServerContext.PackagePath;

var packagePath = httpServerContext.PackagePath;

if (string.IsNullOrEmpty(packagePath))

{

throw new ArgumentException("Package path must not be null or empty.", nameof(packagePath));

}

Copilot · 2025-10-30T19:36:17Z

src/WebExpress.WebCore/WebHtml/HtmlElement.cs

+                        }
+                        builder.Append(nestedListText);
+                        break;
+                    case HtmlElement element:


This assignment to element is useless, since its value is never read.

ReneSchwarzer added 30 commits April 18, 2025 17:53

feat: begin development of version 0.0.9-alpha

298cc99

add: reference to WebExpress.Tutorial.WebUI

0dccf68

feat: general improvements

6c394c6

add: implement method chaining for fluent interface

d2cb473

feat: general improvements

9639583

add: new css concatenate method

300f973

feat: general improvements

3641428

add: find method

a416a87

add: new web ui interface for ui elements like fragments or controls

1be0919

feat: improved the web ui interface

3fc6086

feat: improved the html elements

77d17bf

feat: general improvements

2f693c6

feat: general improvements

5966e5d

fix: base header

7b08372

feat: improved the uri

4ce98a7

feat: introduced typed API responses for better result handling

ca6eed5

add: rest api validator

c5e095a

feat: updated AssetManager

ed2ba1d

- now registers each individual asset instead of just the base path

add: support for DebugLocal configuration

41531cf

feat: removed Markdig dependency and implemented custom markdown

789cac1

add: smart editcontrol

1246aa9

update: dependent package

7492a8d

feat: improved breadcrumb control and minor bugs

2706f03

feat: general improvements and minor bugs

6ca7dc1

feat: general improvements and minor bugs

397a9a0

feat: add avatar input control, general improvements and minor bugs

c2b6326

feat: add RestProgressTask control, general improvements and minor bugs

d982940

feat: add fragment page, general improvements and minor bugs

20ee76f

- refactor: restructure WebExpress

58ebab6

refactor: restructure WebExpress

d6688e5

ReneSchwarzer added 18 commits September 24, 2025 21:33

feat: add responsive control, general improvements and minor bugs

56de7f4

add: GitHub actions workflow for C# build and xUnit tests

704a50e

fix: GitHub actions workflow for C# build and xUnit tests

fa16f3f

add: enable manual trigger via workflow_dispatch

f527af3

fix: GitHub actions workflow for C# build and xUnit tests

0730534

feat: general improvements and minor bugs

2976d9d

fix: documentation build

72a539d

fix: general improvements and minor bugs

9ca43d5

fix: general improvements and minor bugs

43ace7b

feat: general improvements and minor bugs

938ed24

feat: improved reverse index and minor bugs

73dd2b8

feat: general improvements and minor bugs

5583017

feat: add include manager, general improvements and minor bugs

4308260

refactor: replace role terminology with policy

e8bb24e

fix: include manager improvements

ee1b6a6

feat: add rest dropdown control, general improvements and minor bugs

b3e8778

feat: general improvements and minor bugs

17d293a

feat: general improvements and minor bugs

48da9a7

ReneSchwarzer self-assigned this Oct 29, 2025

ReneSchwarzer requested a review from Copilot October 29, 2025 17:21

Copilot AI reviewed Oct 29, 2025

View reviewed changes

ReneSchwarzer changed the title ~~Develop~~ 0.0.9-alpha Oct 29, 2025

fix: applied improvements from code review

094cdd9

ReneSchwarzer requested a review from Copilot October 30, 2025 18:05

Copilot AI reviewed Oct 30, 2025

View reviewed changes

fix: applied improvements from code review

fc6d3a8

ReneSchwarzer requested a review from Copilot October 30, 2025 19:28

Copilot AI reviewed Oct 30, 2025

View reviewed changes

fix: applied improvements from code review

7a8996b

ReneSchwarzer merged commit 12fc57a into main Oct 31, 2025
1 check failed

		/// This method appends the specified errors to the existing collection. If
		/// the array isempty, no changes are made.

		/// A function that evaluates the request and returns true" if the
		/// condition is met; otherwise,false.

Conversation

ReneSchwarzer commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025