fix(ai-transformation): development-ai-transformation#700
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d58b5f5e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Post intake JSON comment (see [development-phase-plan.md](../../ai-docs/harness/development-phase-plan.md) §8.2) | ||
|
|
||
| ``` | ||
| mcp__jira__add_labels(issueKey="{TICKET_ID}", labels=["dev-ready", "dev-in-progress"]) |
There was a problem hiding this comment.
Use the Jira label parameter expected by MCP
The existing Jira MCP examples in this repo call mcp__jira__add_labels with issue_key (for example, .claude/commands/scrub.md and .claude/commands/fix.md), but the new dev workflow uses issueKey here and in /dev-pr and /dev-post-merge. When /dev-start reaches the label step, the parent agent will try to call the tool with the wrong argument name, so the ticket will not get the dev-ready/dev-in-progress state that later stages use as durable workflow state. Please use issue_key consistently in the new dev commands.
Useful? React with 👍 / 👎.
| ### Step 3: Worktree | ||
|
|
||
| ```bash | ||
| git worktree add /tmp/claude-widgets/{TICKET_ID} -b {TICKET_ID} |
There was a problem hiding this comment.
Base development worktrees on next
When /dev-start is run from any checkout other than the latest next, this creates {TICKET_ID} from the caller's current HEAD because git worktree add -h shows the base commit is the optional <commit-ish> argument and none is supplied here. The PR flow later targets next, so a dev ticket can include stale or unrelated commits in its branch; the existing /fix workflow avoids this by fetching upstream next and passing upstream/next. Fetch and supply the next ref here (and in the duplicate snippet in 00-master.md).
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.