-
Notifications
You must be signed in to change notification settings - Fork 65
Merge rtt with next #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kesari3008
wants to merge
6
commits into
webex:next
Choose a base branch
from
Kesari3008:merge-rtt-with-next
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge rtt with next #666
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1e79df7
tooling(deploy): add rtt in branch allow list
Shreyas281299 90879db
tooling(pull-request): remove target branch in pull-request workflow
Shreyas281299 b067344
fix(store): change to publish all widgets (#659)
Shreyas281299 f75a3c0
feat(ccwidgets): Real Time Transcript Widget Implementation (#653)
Kesari3008 83e5bf8
Merge branch 'next' of https://github.com/webex/widgets into merge-rt…
Kesari3008 e9acd6c
feat(ccwidgets): merge rtt feature branch
Kesari3008 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
...tact-center/cc-components/src/components/task/RealTimeTranscript/real-time-transcript.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| import React, {useMemo} from 'react'; | ||
| import {Avatar} from '@momentum-design/components/dist/react'; | ||
| import {withMetrics} from '@webex/cc-ui-logging'; | ||
| import {RealtimeTranscriptComponentProps} from '../task.types'; | ||
| import './real-time-transcripts.style.scss'; | ||
|
|
||
| const formatSpeaker = (speaker?: string) => speaker || 'Unknown'; | ||
|
|
||
| const RealTimeTranscriptComponent: React.FC<RealtimeTranscriptComponentProps> = ({ | ||
| ivrTranscript = '', | ||
| liveTranscriptEntries = [], | ||
| activeTab = 'live', | ||
| onTabChange, | ||
| className, | ||
| }) => { | ||
| const sortedEntries = useMemo( | ||
| () => | ||
| [...liveTranscriptEntries].sort((a, b) => { | ||
| if (a.timestamp === b.timestamp) return 0; | ||
| return a.timestamp > b.timestamp ? 1 : -1; | ||
| }), | ||
| [liveTranscriptEntries] | ||
| ); | ||
|
|
||
| return ( | ||
| <section className={`real-time-transcript ${className || ''}`.trim()} data-testid="real-time-transcript:root"> | ||
| <div className="real-time-transcript__tabs" role="tablist" aria-label="Conversation transcript tabs"> | ||
| <button | ||
| type="button" | ||
| role="tab" | ||
| aria-selected={activeTab === 'live'} | ||
| className={`real-time-transcript__tab ${activeTab === 'live' ? 'real-time-transcript__tab--active' : ''}`.trim()} | ||
| onClick={() => onTabChange?.('live')} | ||
| data-testid="real-time-transcript:live-tab" | ||
| > | ||
| Live transcript | ||
| </button> | ||
| </div> | ||
|
|
||
| {activeTab === 'ivr' ? ( | ||
| <div className="real-time-transcript__empty" data-testid="real-time-transcript:ivr-content"> | ||
| {ivrTranscript || 'No IVR transcript available.'} | ||
| </div> | ||
| ) : ( | ||
| <div className="real-time-transcript__content" data-testid="real-time-transcript:live-content"> | ||
| {sortedEntries.length === 0 ? ( | ||
| <div className="real-time-transcript__empty">No live transcript available.</div> | ||
| ) : ( | ||
| <> | ||
| {sortedEntries[0].event ? ( | ||
| <div className="real-time-transcript__event" data-testid="real-time-transcript:first-event"> | ||
| {sortedEntries[0].event} | ||
| </div> | ||
| ) : null} | ||
| {sortedEntries.map((entry) => ( | ||
| <div key={entry.id} className="real-time-transcript__item" data-testid="real-time-transcript:item"> | ||
| <div className="real-time-transcript__avatar-wrap"> | ||
| {entry.avatarUrl ? ( | ||
| <img | ||
| src={entry.avatarUrl} | ||
| alt={formatSpeaker(entry.speaker)} | ||
| className="real-time-transcript__avatar-image" | ||
| /> | ||
| ) : ( | ||
| <Avatar | ||
| className="real-time-transcript__avatar-fallback" | ||
| icon-name={entry.isCustomer ? undefined : 'placeholder-bold'} | ||
| title={formatSpeaker(entry.speaker)} | ||
| > | ||
| {entry.initials || (entry.isCustomer ? 'CU' : 'YO')} | ||
| </Avatar> | ||
| )} | ||
| </div> | ||
| <div className="real-time-transcript__text-block"> | ||
| <div className="real-time-transcript__meta"> | ||
| <span>{formatSpeaker(entry.speaker)}</span> | ||
| {entry.displayTime ? ( | ||
| <span className="real-time-transcript__time">{entry.displayTime}</span> | ||
| ) : null} | ||
| </div> | ||
| <p className="real-time-transcript__message">{entry.message}</p> | ||
| </div> | ||
| </div> | ||
| ))} | ||
| </> | ||
| )} | ||
| </div> | ||
| )} | ||
| </section> | ||
| ); | ||
| }; | ||
|
|
||
| const RealTimeTranscriptComponentWithMetrics = withMetrics(RealTimeTranscriptComponent, 'RealTimeTranscript'); | ||
|
|
||
| export default RealTimeTranscriptComponentWithMetrics; | ||
103 changes: 103 additions & 0 deletions
103
...ter/cc-components/src/components/task/RealTimeTranscript/real-time-transcripts.style.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| .real-time-transcript { | ||
| background: var(--mds-color-theme-background-primary-normal); | ||
| border-radius: 0.5rem; | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 12rem; | ||
| padding: 0.75rem 0.875rem; | ||
| } | ||
|
|
||
| .real-time-transcript__tabs { | ||
| align-items: center; | ||
| column-gap: 1.5rem; | ||
| display: flex; | ||
| margin-bottom: 0.75rem; | ||
| } | ||
|
|
||
| .real-time-transcript__tab { | ||
| background: transparent; | ||
| border: 0; | ||
| border-bottom: 0.125rem solid transparent; | ||
| color: var(--mds-color-theme-text-secondary-normal); | ||
| cursor: pointer; | ||
| font-size: 0.9375rem; | ||
| font-weight: 500; | ||
| line-height: 1.25rem; | ||
| padding: 0.125rem 0; | ||
| } | ||
|
|
||
| .real-time-transcript__tab--active { | ||
| border-bottom-color: var(--mds-color-theme-text-primary-normal); | ||
| color: var(--mds-color-theme-text-primary-normal); | ||
| font-weight: 700; | ||
| } | ||
|
|
||
| .real-time-transcript__content { | ||
| display: flex; | ||
| flex: 1; | ||
| flex-direction: column; | ||
| overflow-y: auto; | ||
| row-gap: 0.875rem; | ||
| } | ||
|
|
||
| .real-time-transcript__event { | ||
| color: var(--mds-color-theme-text-secondary-normal); | ||
| font-size: 0.75rem; | ||
| line-height: 1rem; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .real-time-transcript__item { | ||
| align-items: flex-start; | ||
| column-gap: 0.625rem; | ||
| display: flex; | ||
| } | ||
|
|
||
| .real-time-transcript__avatar-wrap { | ||
| flex-shrink: 0; | ||
| height: 1.75rem; | ||
| width: 1.75rem; | ||
| } | ||
|
|
||
| .real-time-transcript__avatar-image { | ||
| border-radius: 50%; | ||
| display: block; | ||
| height: 100%; | ||
| object-fit: cover; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .real-time-transcript__avatar-fallback { | ||
| --mdc-avatar-size: 1.75rem; | ||
| } | ||
|
|
||
| .real-time-transcript__text-block { | ||
| min-width: 0; | ||
| } | ||
|
|
||
| .real-time-transcript__meta { | ||
| color: var(--mds-color-theme-text-secondary-normal); | ||
| display: flex; | ||
| font-size: 0.75rem; | ||
| line-height: 1rem; | ||
| } | ||
|
|
||
| .real-time-transcript__time { | ||
| color: #2e6de5; | ||
| margin-left: 0.5rem; | ||
| text-decoration: underline; | ||
| } | ||
|
|
||
| .real-time-transcript__message { | ||
| color: var(--mds-color-theme-text-primary-normal); | ||
| font-size: 1.0625rem; | ||
| line-height: 1.5rem; | ||
| margin: 0.125rem 0 0; | ||
| } | ||
|
|
||
| .real-time-transcript__empty { | ||
| color: var(--mds-color-theme-text-secondary-normal); | ||
| font-size: 0.875rem; | ||
| line-height: 1.25rem; | ||
| padding: 1rem 0.125rem; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component models two tabs (
'ivr' | 'live') and has separate IVR rendering, but the tablist renders only a Live tab and its handler only emits'live'. In the default state, users have no in-component way to switch to IVR content, soivrTranscriptis effectively inaccessible unless a parent forcesactiveTab='ivr'externally.Useful? React with 👍 / 👎.