Skip to content

fix(meetings): address version resolution #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riteshfyi wants to merge 4 commits into
base: next
Choose a base branch
from
Open

fix(meetings): address version resolution #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a7248f
fix(meetings): address version conflict
riteshfyi Mar 30, 2026
95549a0
fix(meetings): move devDependency to root
riteshfyi Mar 30, 2026
4a13143
fix(meetings): remove multiple versions
riteshfyi Mar 30, 2026
7baa039
fix(meetings): mention missing devdependency
riteshfyi Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@
],
"packageManager": "yarn@4.5.1",
"devDependencies": {
"@babel/plugin-transform-runtime": "^7.29.0",
"@babel/preset-typescript": "7.25.9",
"@playwright/test": "^1.51.1",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/exec": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"@semantic-release/github": "^11.0.1",
"@testing-library/react-hooks": "^8.0.1",
"@types/babel__plugin-transform-runtime": "^7",
"@webex/cli-tools": "0.0.0-next.2",
"@webex/package-tools": "0.0.0-next.6",
"babel-jest": "^29.7.0",
Expand Down
6 changes: 5 additions & 1 deletion packages/@webex/widgets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"engines": {
"node": ">=20.13.1"
},
"installConfig": {
"hoistingLimits": "dependencies"
},
"main": "dist/webexWidgets.mjs",
"module": "dist/webexWidgets.mjs",
"scripts": {
Expand Down Expand Up @@ -53,6 +56,7 @@
"@babel/plugin-transform-runtime": "^7.16.0",
"@babel/preset-env": "^7.8.4",
"@babel/preset-react": "^7.8.3",
"@babel/register": "^7.25.9",
"@commitlint/cli": "^8.3.5",
"@commitlint/config-conventional": "^8.3.4",
"@momentum-ui/react": "^23.21.4",
Expand Down Expand Up @@ -117,7 +121,7 @@
"prop-types": "^15.7.2",
"react": "18.3.1",
"react-dom": "18.3.1",
"webex": "2.60.2"
"webex": "2.60.4"
},
"babel": {
"presets": [
Expand Down
2 changes: 2 additions & 0 deletions packages/@webex/widgets/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ module.exports = function(env, argv) {
include: [
resolveMonorepoRoot('node_modules/@momentum-ui'),
resolveMonorepoRoot('node_modules/@webex/components'),
path.resolve(__dirname, 'node_modules/@momentum-ui'),
path.resolve(__dirname, 'node_modules/@webex/components'),
path.resolve(__dirname, 'packages'),
],
},
Expand Down
3 changes: 2 additions & 1 deletion widgets-samples/samples-meeting-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
"serve": "webpack serve --mode development"
},
"dependencies": {
"@momentum-ui/react": "^23.21.4",
"@webex/widgets": "workspace:*",
"prop-types": "^15.7.2",
"react": "18.3.1",
"react-dom": "18.3.1",
"webex": "2.60.2"
"webex": "2.60.4"
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep sample Webex version compatible with widget peer

Updating the sample app to webex: 2.60.4 makes it incompatible with @webex/widgets' declared peer requirement (webex: 2.60.2 in packages/@webex/widgets/package.json), so installs now produce a peer-dependency conflict and can fail in strict-peer environments. This undercuts the stated goal of stabilizing dependency resolution; either the sample should stay on 2.60.2 or the widget peer range should be updated to include 2.60.4.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

@riteshfyi riteshfyi Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crucial for the fix

},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
7 changes: 7 additions & 0 deletions widgets-samples/samples-meeting-app/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ module.exports = function(env, argv) {
devtool: argv.mode === 'production' ? 'source-map' : 'inline-source-map',
resolve: {
extensions: ['.js', '.jsx'],
alias: {
react: path.dirname(require.resolve('react/package.json')),
'react-dom': path.dirname(require.resolve('react-dom/package.json')),
'prop-types': path.dirname(require.resolve('prop-types/package.json')),
webex: path.resolve(path.dirname(require.resolve('webex')), '..'),
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve Webex alias from widgets workspace

This alias is resolved from samples-meeting-app and therefore does not point to packages/@webex/widgets/node_modules; Node resolution from this file only walks the sample app’s ancestor directories. In environments with multiple hoisted versions, the sample can still bind to a different webex copy than @webex/widgets, which reintroduces the version-skew problem this patch is trying to fix.

Useful? React with 👍 / 👎.

'@webex/common': path.dirname(require.resolve('@webex/common/package.json')),
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid resolving transitive @webex/common at startup

Evaluating this require.resolve('@webex/common/package.json') at config-load time assumes @webex/common is hoisted to a location visible from the sample app. If hoisting changes (for example due to installConfig.hoistingLimits or version conflicts), @webex/common can remain nested under webex and webpack fails before compilation starts. This should be made independent of hoisting (or declared as a direct dependency).

Useful? React with 👍 / 👎.

},
fallback: {
"buffer": require.resolve("buffer/"),
"crypto": require.resolve("crypto-browserify"),
Expand Down
Loading
Loading