fix(meetings): incorrect handling of control update in API responses#4828
Merged
JudyZhuHz merged 2 commits intowebex:nextfrom Apr 3, 2026
Merged
fix(meetings): incorrect handling of control update in API responses#4828JudyZhuHz merged 2 commits intowebex:nextfrom
JudyZhuHz merged 2 commits intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
mickelr
approved these changes
Apr 3, 2026
JudyZhuHz
approved these changes
Apr 3, 2026
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-794239
This pull request addresses
Locus sends updates for control entries in an inconsistent way. When they come in messages, the htMeta field is at the same level as the control entry key, while in API responses it is 1 level below.
For example:
locked status update in a message contains an entry like this in locusStateElements array:
while in the API responses, the entry for lock status inside locus.controls looks like this:
so when parsing API response, we need to keep track of the name of the parent prop and create the data object so that it contains that parent prop as the top level key.
by making the following changes
updated the code for parsing hash tree api responses.
Change Type
The following scenarios were tested
unit tests, manual e2e test with web app on convergedats
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.