feat(plugin-meetings): add AV1 codec support and related constants#4816
feat(plugin-meetings): add AV1 codec support and related constants#4816fnowakow wants to merge 14 commits intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
|
||
| if (mr.codecInfo) { | ||
| const h264CodecInfo = WcmeCodecInfo.fromH264( | ||
| 0x80, |
There was a problem hiding this comment.
getIngressPayloadType is available in multistream connection, that we don't have access in mediaRequestManager
Should we delegate creating WcmeCodecInfo.fromAv1 and fromH264 in WCME/media-core?
Currently do update this values we either need to pass mediaconnection to mediaRequestManager (or proxy it like sendMediaRequestCallback - smth like getIngressPayloadTypeSupplier()) or update it when we have access to media connection (current changes)
Currently we also need to have imports for
CodecInfo - js-sdk encoding params for buildingAv1/H264Codec
[Av1/H264]Codec - jmp encoding params for building WcmeCodecInfo
WcmeCodecInfo - json-multistream class to build codecinfo in jmp message
This should be simplified in wcme so at this level (js-sdk) we don't need to use json-multistream classes and calculate payload type
…r multistream media requests
| kind: 'video', | ||
| trimRequestsToNumOfSources: false, | ||
| // @ts-ignore - config coming from registerPlugin | ||
| enableAV1: this.config.enableAV1VideoSlides, |
There was a problem hiding this comment.
I think we should use enableAv1? and across all other places.
Look that we have for example backendIpv6NativeSupport not backendIPV6NativeSupport. We don't use HTML, but rather Html semantic
There was a problem hiding this comment.
refers to all occurences
| degradationPreferences: { | ||
| maxMacroblocksLimit: 8192, | ||
| }, | ||
| // !! TODO: this is a temporary config to enable AV1 video slides for testing purposes |
There was a problem hiding this comment.
We don't need this comment. I believe it's not for testing only, but we should keep this for longer period of time
4 participants
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.