fix(ci): move comment workflow to deploy-cd by riteshfyi · Pull Request #4814 · webex/webex-js-sdk

riteshfyi · 2026-03-27T07:34:17Z

COMPLETES #NA

This pull request addresses

We are moving the pr-comment-workflow to deploy-cd. so we don't have to re-fetch the package changes

by making the following changes

Moves the PR release comment logic from its own workflow into deploy.yml as a final job, so it runs after the full deploy pipeline completes. Uses the increment step output directly for per-package versions instead of re-reading the changelog.

We are logging the output of the yarn increment step during npm-publish to a variable, so we are able to get the updated packages & their latest version.

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
[] Tooling change
Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

riteshfyi · 2026-03-27T07:35:06Z

Test Comment Link : riteshfyi#8 (comment)

riteshfyi · 2026-03-27T08:22:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 393f72d9e3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-27T08:27:28Z

.github/workflows/deploy.yml

+
+  comment-on-pr:
+    name: Comment on Released PRs
+    needs: [publish-npm, publish-tag]


Gate PR release comments on full deploy success

comment-on-pr is intended to run after the full deploy pipeline, but its needs only includes publish-npm and publish-tag. If publish-documentation fails, this job can still post “Your changes are now available,” which is a regression from the previous workflow_run-based flow that only ran when Deploy CD concluded successfully; this can produce incorrect release notifications for partially failed deployments.

Useful? React with 👍 / 👎.

if publish-npm, publish-tag has happened already. then the package is already in production. also publish-documentation gets skipped in some scenarios as well.

vamshigovardhana · 2026-03-30T11:44:16Z

.github/workflows/deploy.yml

+              const prs = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+                owner, repo, commit_sha: deploySha
+              });
+              const mergedPR = prs.data.find(pr => pr.merged_at);


.find() only returns the first merged PR — if multiple merged PRs are associated with this commit (back-to-back merges), the rest get silently skipped? Will this work for that case?

deploySha is unique for each pull-request, so this won't happen.

riteshfyi · 2026-03-30T12:51:02Z

@vamshigovardhana right now we are fetching 200 comments to verify if we have any pre-exisiting comment, which we can upgrade, like a general one.
should we increase the limit?

vamshigovardhana · 2026-03-31T06:48:05Z

@vamshigovardhana right now we are fetching 200 comments to verify if we have any pre-exisiting comment, which we can upgrade, like a general one. should we increase the limit?

@riteshfyi I think GitHub's API silently caps per_page at 100 -- passing 200 just returns 100 with no error, so increasing the number won't help. why don't we Use github.paginate() instead? which automatically fetches all pages regardless of how many comments exist.

mkesavan13 · 2026-03-31T13:04:38Z

.github/workflows/deploy.yml

+            const owner = 'webex';
+            const repo = 'webex-js-sdk';


Can't these be dynamic? Why do we need to hard code these?

actually it was dynamic earlier, in a review i was suggested to hard-code it, yeah, let's make it dynamic again

mkesavan13 · 2026-03-31T13:09:15Z

.github/workflows/deploy.yml

+            for (const line of raw.split('\n')) {
+              const match = line.match(/^__webex_release__:\s+(.+?)\s+=>\s+(.+)$/);
+              if (match) packageVersions[match[1].trim()] = match[2].trim();
+            }


Why can't this version match happen in the place where we extract __webex_release__: lines?

Seems to be a redundant loop

just a question kesava, should the job responsible for incrementing the package version, be doing this ?. i feel like it seems a little out of context for that job,

I did the changes, but that method was very prone to bugs, it introduced 3 bugs which i could identify directly. even after multiple changes, the final appraoch still felt like, that was not good for production. also it was not readable also.

mkesavan13 · 2026-03-31T13:10:53Z

.github/workflows/deploy.yml

+              const primaryPackage = packageVersions['webex']
+                ? 'webex'
+                : packageEntries.filter(([p]) => p !== 'webex' && p !== 'webex-node').map(([p]) => p)[0] || packageEntries[0][0];


This condition seems to check packageVersions['webex'] is matching to the string webex itself. Would this ever match?

Actually here,
it tries to find a relevant primary pacakge for the changelog url, if 'webex' is falsy or not present in the primaryPackage list, it will filter the 'webex' & 'webex-node' packages & select a random pacakge for the changelog url.

mkesavan13 · 2026-03-31T13:12:27Z

.github/workflows/deploy.yml

+              const primaryVersion = packageVersions[primaryPackage];
+              const stableVersion = primaryVersion.replace(/-next\..*/, '').replace(/-[a-z]*\..*/, '');
+
+              const changelogUrl = new URL('https://web-sdk.webex.com/changelog/');


This base URL is mapped as a custom domain in the repo.

This setting sits here: https://github.com/webex/webex-js-sdk/blob/next/docs/CNAME

Can we find a way to use this so that we won't have to hardcode this?

mkesavan13 · 2026-03-31T13:15:30Z

.github/workflows/deploy.yml

+                packagesTable,
+                'Thank you for your contribution!',
+                '',
+                `_:robot: This is an automated message. For questions, please refer to the [documentation](${repoUrl}#readme)._`


We should rather reword this like this:

Suggested change

`_:robot: This is an automated message. For questions, please refer to the [documentation](${repoUrl}#readme)._`

`_:robot: This is an automated message. For queries, please contact [support](https://developer.webex.com/support)._`

Yup, indeed better.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3a8e0de9f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-01T04:01:44Z

.github/workflows/deploy.yml

+          echo "$OUTPUT"
+          VERSIONS_JSON=$(printf '%s\n' "$OUTPUT" | grep -E '^(@webex/|webex[^ ]*) => ' | \
+            jq -Rn '[inputs | split(" => ")] | map({(.[0]): .[1]}) | add // {}')
+          echo "package_versions=$VERSIONS_JSON" >> $GITHUB_OUTPUT


Emit compact JSON before setting package_versions output

jq -Rn emits pretty-printed JSON by default, so VERSIONS_JSON contains embedded newlines here; writing it as package_versions=$VERSIONS_JSON produces a multi-line GITHUB_OUTPUT entry, which the runner treats as an invalid output format unless heredoc syntax is used. In runs where packages are incremented, this can fail publish-npm before downstream jobs can read needs.publish-npm.outputs.package_versions.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-01T04:01:44Z

.github/workflows/deploy.yml

+        run: |
+          OUTPUT=$(yarn package-tools increment --packages ${{ needs.generate-package-matrix.outputs.node-recursive }} --tag ${GITHUB_REF##*/})
+          echo "$OUTPUT"
+          VERSIONS_JSON=$(printf '%s\n' "$OUTPUT" | grep -E '^(@webex/|webex[^ ]*) => ' | \


Tolerate empty increment output when extracting package versions

This pipeline relies on grep producing at least one match, but when no packages are incremented (a case the workflow already models via hasPackages/proceed=false), grep -E exits with status 1 and the step fails under GitHub Actions' bash -eo pipefail defaults. That turns a valid no-package deploy into a hard failure in publish-npm.

Useful? React with 👍 / 👎.

riteshfyi · 2026-04-01T04:42:43Z

@vamshigovardhana @mkesavan13 i'm done with my changes,
will verify the code in production with my npm account once before merge.
please let me know if you all have any more reviews.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c9dd0bc52

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-01T04:47:22Z

.github/workflows/deploy.yml

+              const primaryVersion = packageVersions[primaryPackage];
+              const stableVersion = primaryVersion.replace(/-next\..*/, '').replace(/-[a-z]*\..*/, '');
+
+              const cnameFile = await github.rest.repos.getContent({ owner, repo, path: 'docs/CNAME' });


Guard CNAME lookup failures before composing comment body

Handle github.rest.repos.getContent({ path: 'docs/CNAME' }) failures before building the release comment, because this call is currently outside the try/catch used for comment posting. If the API call fails (for example due to a transient GitHub API error or a missing/renamed docs/CNAME on the default branch), the comment-on-pr job hard-fails and marks Deploy CD failed even after publish-npm/publish-tag have succeeded.

Useful? React with 👍 / 👎.

should we add a fallback here?

riteshfyi and others added 18 commits March 17, 2026 11:08

fix(ci): disable changelog comment

663b017

fix(ci): clean bot code

61ae501

Merge branch 'next' into pr

071a3c3

fix(ci): fix comment bot inputs

45f96e7

fix(ci): update bot comment

22d50ed

fix(ci): change comment-bot logic

f2c1934

fix(ci): remove unnecessary logs

88a7f68

fic(ci): remove dead branch

0da795c

fix(ci): update file name

bbf3739

fix(ci): update pagination to comments

8b6a723

Merge branch 'next' into pr

8a9871c

fix(ci): update commit check logic

f5159d8

Merge remote-tracking branch 'origin/pr' into pr

64c4641

Merge branch 'next' into pr

d8dd981

fix(ci): move file to job

d06d57e

Merge remote-tracking branch 'origin/pr' into pr

6f9d89c

fix(ci): update comment workflow

f14eb75

fix(ci): update log prefix

779a438

riteshfyi requested a review from a team as a code owner March 27, 2026 07:34

Merge branch 'next' into pr

61bcc4c

fix(ci): remove workflow file

393f72d

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

vamshigovardhana reviewed Mar 30, 2026

View reviewed changes

mkesavan13 requested changes Mar 31, 2026

View reviewed changes

fix(ci): cleaner approach

b3a8e0d

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

fix(ci): cleaner approach

1c9dd0b

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

fix(ci): simplify

86bdabd

	`_:robot: This is an automated message. For questions, please refer to the [documentation](${repoUrl}#readme)._`
	`_:robot: This is an automated message. For queries, please contact [support](https://developer.webex.com/support)._`

Conversation

riteshfyi commented Mar 27, 2026

COMPLETES #NA

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

Uh oh!

riteshfyi commented Mar 27, 2026

Uh oh!

riteshfyi commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riteshfyi commented Mar 30, 2026

Uh oh!

vamshigovardhana commented Mar 31, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riteshfyi Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riteshfyi Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

riteshfyi Mar 31, 2026 •

edited

Loading

riteshfyi Mar 31, 2026 •

edited

Loading

riteshfyi commented Apr 1, 2026 •

edited

Loading