Skip to content

feat(jmt): update getClientJMT calculations#4806

Draft
gabrielchl wants to merge 1 commit intowebex:nextfrom
gabrielchl:SPARK-782074-feat-update-get-client-jmt-metric
Draft

feat(jmt): update getClientJMT calculations#4806
gabrielchl wants to merge 1 commit intowebex:nextfrom
gabrielchl:SPARK-782074-feat-update-get-client-jmt-metric

Conversation

@gabrielchl
Copy link
Copy Markdown
Contributor

COMPLETES https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-782074

This pull request addresses

inaccuracies in getClientJMT calculations

by making the following changes

using the right latencies to calculate getCleintJMT

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4806.d3m3l2kee0btzx.amplifyapp.com

@gabrielchl
Copy link
Copy Markdown
Contributor Author

we wanna leave this for last, esp. after natalia's PR to modify clickToInterstitial calc goes in, leaving as a draft pr for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant