Skip to content

feat(jmt): update getShowInterstitialTime start metric#4796

Open
gabrielchl wants to merge 1 commit intowebex:nextfrom
gabrielchl:SPARK-782063/feat-update-getShowInterstitialTime-start-metric
Open

feat(jmt): update getShowInterstitialTime start metric#4796
gabrielchl wants to merge 1 commit intowebex:nextfrom
gabrielchl:SPARK-782063/feat-update-getShowInterstitialTime-start-metric

Conversation

@gabrielchl
Copy link
Copy Markdown
Contributor

@gabrielchl gabrielchl commented Mar 23, 2026

COMPLETES https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-782063

This pull request addresses

inaccurate starting timestamp used for getShowInterstitialTime

by making the following changes

changing the start of this latency from 'client.interstitial-window.start-launch' to 'internal.client.meeting.interstitial-window.showed', which is the "end point" of "getClickToInterstitial"

this will make showInterstitialTime a bit shorter (around .5 - 1s)

tested with guest join, sign in join and x-launch join

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@gabrielchl gabrielchl requested review from a team as code owners March 23, 2026 13:32
@gabrielchl gabrielchl added the validated If the pull request is validated for automation. label Mar 23, 2026
@gabrielchl gabrielchl marked this pull request as draft March 23, 2026 15:37
@gabrielchl
Copy link
Copy Markdown
Contributor Author

debugging issue where client.call.initiated seems to not be sent

@gabrielchl gabrielchl marked this pull request as ready for review March 31, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant