fixed parsing the timezone when reading API response#22
fixed parsing the timezone when reading API response#22ralfschiffert wants to merge 1 commit intowebex:masterfrom
Conversation
|
Ralf, since you created this Pull Request we released a contributing guide. In order for us to properly merge this pull request, it must meet the standards of the guide. Can you please adjust the git commit message[s] to match the requirements of the guide. We would at least need a header and a body for the commit. Thanks |
jbenyovs
left a comment
There was a problem hiding this comment.
Looks good to me, other than the commit changes detailed above.
|
@jbenyovs it doesn't look like the original PR submitter will be replying back. Would you be able to fix this bug out of band? It seems strange that a 3 character fix has been blocked for 3 years because the submitter went away. Without this simple fix the timestamps (e.g., last activity) are consistently off by several hours unless you happen to live in GMT. |
We parse the timezone in the API response wrong. This is before the fix when I query any resource like people/me
people/me
API response
"created": "2017-10-26T23:11:32.021Z",
"lastActivity": "2019-02-22T19:03:25.661Z",
"status": "inactive",
SDK response
created: Thu Oct 26 23:11:32 PDT 2017
lastActivity: Fri Feb 22 19:03:25 PST 2019
This is after the fix with the correct translation of Zulu time to local time
Thu Oct 26 16:11:32 PDT 2017
Fri Feb 22 11:03:25 PST 2019