Use cargo_metadata to get manifest data (adds workspace inheritance support)#82
Use cargo_metadata to get manifest data (adds workspace inheritance support)#82oeb25 wants to merge 1 commit intowebern:mainfrom
cargo_metadata to get manifest data (adds workspace inheritance support)#82Conversation
This commit uses the `cargo_metadata` crate to derive information about
the crate, as opposed to only parsing `Cargo.toml`.
In particular, this helps when fields in the manifest are inherited from
the workspace, for example if `version = { workspace = true }`.
One thing `cargo_metadata` does not provide, is badges, so these are
still parsed from `Cargo.toml`.
The error messages also changed as a result of propagating the errors
from `cargo_metadata`, and thus some of the tests had to be altered.
|
This is great, thåmbs up! It is the better way of resolving: I'd like to take bring it to the end goal. Since it comes from If you'd like, perhaps you can rebase this and I can see if I can start the CI build and review. If you're not interested, I will open another PR and cherry-pick your changes for attribution. |
cargo_metadata to get manifest datacargo_metadata to get manifest data (adds workspace inheritance support)
You might be able to? Maybe it involves using the |
|
There's a deliberate limitation on GitHub which prevents maintainers of the original repo from pushing to the forked master/main branch of a pull request. It has some kind of special status. Since the PR is quite old, the workaround might not be too bad. |
This commit uses the
cargo_metadatacrate to derive information about the crate, as opposed to only parsingCargo.toml.In particular, this helps when fields in the manifest are inherited from the workspace, for example if
version = { workspace = true }.One thing
cargo_metadatadoes not provide, is badges, so these are still parsed fromCargo.toml.The error messages also changed as a result of propagating the errors from
cargo_metadata, and thus some of the tests had to be altered.