feat(expect-webdriverio): add toHaveLocalStorageItem matcher#1900
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
Thanks for the contribution and sorry for the delayed review. One request, can we ipdate the API docs: https://github.com/webdriverio/expect-webdriverio/blob/main/docs/API.md
7589af9 to
17b882d
Compare
|
Thanks for your review! |
|
@NaamuKim mhm 🤔 seems like some tests are failing:
|
|
@christian-bromann I added types to matchers, can you rerun the tests? |
christian-bromann
left a comment
There was a problem hiding this comment.
Great stuff, thanks a lot 👍
|
@NaamuKim it seems like there is still a valid test error: |
|
@NaamuKim, do you want a hand with this one to finish it up? |
|
@dprevost-LMI I suggest let's get this over the goal line |
dprevost-LMI
left a comment
There was a problem hiding this comment.
Nice matcher.
FYI: Following support of $$(), I'll adapt some code personally later on!
Thanks for the contribution!

What I do
Added tests with the toHaveLocalStorageItem function
Why this function is needed
before
after
If you need anything else, let me know and I'll get it implemented quickly.
If this API is okay, I'll also add a PR for Session storage.