fix(ci): remove package-lock.json to fix release-please crash#108
Merged
Conversation
release-please v17 tries to update package-lock.json when bumping versions but crashes with 'Cannot set properties of undefined (setting version)' because this pnpm project's lockfile format differs from what the node strategy expects. Removing the stale npm lockfile and ignoring it going forward. pnpm-lock.yaml remains the canonical lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release workflow fails on every push to main:
Root cause: release-please v17 (
nodestrategy) fetchespackage-lock.jsonand tries to update thepackages[""].versionfield when bumping versions. This project uses pnpm —package-lock.jsonis a stale npm artifact that doesn't have the structure release-please expects.Fix
git rm package-lock.json— removes the stale lockfilepackage-lock.jsonto.gitignoreso it can't re-appearpnpm-lock.yamlremains the canonical lockfile, untouched.Test plan
Cannot set properties of undefinederrorpnpm installstill works (pnpm-lock.yaml unaffected)