Spigot/Paper 1.21.9-1.21.11 support #4239
Conversation
|
Update: Someone tested it on paper and it doesn't work. It gives this error: Not sure what it means yet. Paper 1.21.9 isn't officially released yet so if it's on their end, maybe it will be resolved. |
|
Paper 1.21.9 build 41 is here https://papermc.io/downloads/paper . Paper is now a Hard Fork and new versions are developed along with the snapshots , that is why Paper gets releases on the same day as a Mojang release. 1.21.9 has been available for weeks for developers on the dev/1.21.9branch as was 1.21.8 Thanks Jacob for updating . |
|
I guess I was looking in the wrong places, then. I see now they have a button to show the 1.21.9 builds. Maybe someone that knows more about paper internals could chime in about what this means. Do I just need to target the paper api instead of the spigot api? My server is Spigot though, so I don't want to drop compatibility with that. It's not my decision to make to drop Spigot support either. My end goal was to switch my server over to fabric once the hard fork started forcing me to choose between spigot / paper plugins. I'd like to support both, but I know that will get harder over time. |
|
Just include the Paper API . Its enough just to import to main java and then in your Listening code . Scenerios could be as simple as a name change or KennyTV may have found a optimized way of inputing and exporting data . Mike has a lot of experience with Dynmap and Im sure he looks at the PR's often |
|
I asked on the PaperMC discord and got this response [8:39 PM] remapping from spigot mappings is not available on paper just yet, as we released the update before spigot was out So give it time, it should start working in paper in future versions. Migrating to paper-api, and using paperweight to get Mojang mappings would definitely make it far easier to update to new versions. And it would avoid problems like this, which will be unavoidable for a certain amount of days after every new MC update. I tried for a bit to handle it (for the 1.21.9 helper) but it's not something I want to spend too much time on. |
|
Now works on Paper again, if you download the latest paper jar from today or newer |
jacob1
changed the title
|
I updated this to 1.21.10, and renamed the directories to 1.21.10 (1.21.9 is now a dead version, quickly obsoleted by 1.21.10) |
|
Thanks! Unfortunately, this PR doesn't support the latest Purpur version |
It seems to work fine for me, do you have anything else running besides dynmap on Purpur? |
- MinecraftServer.registryAccess(): ba() -> bg() - Biome registry constant: Registries.aK -> Registries.aN - TileEntity.getBlockPos(): aA_() -> aD_() - World.registryAccess(): K_() -> L_() - NBT.Tag.asString(): p_() -> r_() Based on official Dynmap PR webbukkit#4239 implementation
|
@jbm11208 thanks for the message. I downloaded the latest Purpur build again, and it works. Idk what happened there |
…ointing to the wrong field (BiomeFog::e), it was using the right method (BiomeFog::e()) all along
jacob1
changed the title
|
I updated this PR to support 1.21.11 as well. Lots of obfuscation changes as usual, but nothing too different. This will probably be the last PR I send in for spigot, for a few reasons:
Basically, I just do this for my own use because it's easy. But the next update will be hard, and I don't have the time or need to do that. I'm also hoping that if I say now I'm not updating for 26.1, someone else will come along and figure out the right way to handle that update. I know enough to see that targetting obfuscated method names like this is unsustainable. I think targetting Spigot is unsustainable as well. I'd like to see the next update target Paper, drop support for legacy versions, and modernize the build infrastructure. But I'm not the one to do that, this isn't my personal project and who knows what will be merged. Edit: |
|
Oh no that's a bad news for community. You are the only person now updating this for spigot, while fabric versions are maintained by so many people. But anyway, thank you for your continuously updating for spigot❤️ |
To me it always seemed Spigot is a dead-end by comparison (no thanks to md-5), especially to Paper (not to mention the upcoming Folia), so I reckon Spigot will only spiral after Paper hard-forked away, and likewise I wouldn't think losing Spigot support will be a loss to anyone, except md-5 himself. |
|
hey, Mini from the PaperMC team here. obviously cutting off legacy crud and modernizing the codebase, code architecture and build pipeline sound like a great idea, but also way more work, which needs people to step up and do all that. I don't know much about the current state of dynmap, but if the goal is to just make it work, then using userdev should be enough and way less work. edit: about spigot support I am obviously biased, but you can also see that the majority of users moved on from spigot to paper or forks of papers. dynmap doesn't seem to track server software on bstats, but other popular plugins do, for example FAWE has spigot at 2.5% of users, with paper or forks of paper making up for the rest. additionally, a more practical reason to stop supporting spigot is that while spigot has not even mentioned plugin that access internals (like dynmap) in their note about 26.1, paper has been providing tooling to use mojang mappings and preparing the community for this change for over two years now. we aren't ignorant to the fact that there are legitimate reasons to mess with internals and we want to help plugin authors to do that in the easiest and nicest way possible (even tho we obviously prefer people would use the api whenever possible). |
|
Thanks for the comment! Hmm ... it's good to know that just to keep things running, it isn't too hard. There are a lot of supported versions, each with tons of NMS calls, that's where the problem comes in. It's why I think we should just have one new jar for paper, and not update the old jar (can leave it there for legacy versions I suppose). If I ever have time (which is very limited these days), I may try to do what you said to those lines. I'm definitely a novice when it comes to gradle, but I've been trying to touch a lot of different plugins to learn more Minecraft dev. |
|
Thank you so much for the last couple of updates, Jacob1! I really appreciated them. It's perfectly understandable that interests change. I looked through the forks and found an active one from JLyne who has already migrated to Mojang mappings: https://github.com/JLyne/dynmap. If anyone has the time to pick up this project, it's definitely a good way to get oriented as well. However, the fork itself won't be suitable for most users as it requires an external web server configuration. |
jacob1
changed the title
10 participants
All of the bukkit mappings are updated for 1.21.9/1/21.10. There were a lot of obfuscated method changes, as usual. No major api changes this time.
I did some initial testing and it loads / renders fine. Once the corresponding Fabric PR #4240 is merged, it will also render The Copper Age blocks.
I put a jar download on my fork for anyone that needs it before this PR is merged. (it's a combination of my and reusteur73's PRs so will render the new blocks).
Edit: Updated to 1.21.11. See my note on that down below