Key lastblockNumber by chainName

[soulofmischief]

No description provided.

[avaer]

What is this accomplishing? Are there multiple chains that we are caching? As far as I know that's not the case.

[soulofmischief]

What is this accomplishing? Are there multiple chains that we are caching? As far as I know that's not the case.

I noticed while working on redis-server that the same code was being used for multiple chains and thus lastBlockNumber was being set for mainnetsidechain in all cases, including when processing other chains. If we don't want to save the last block number for other chains, then the solution would be to only put the last block number when the chain name is 'mainnetsidechain'

[avaer]

What does "processing other chains" mean? Which chains? What is being processed? As far as I know there is one chain we run through, mainnetsidechain, for setting up our cache.

Though there are multiple contracts on that chain (3: NFT + Land + Account).

[soulofmischief]

processEventsNft in particular, gets called on both mainnet and polygon on each boot, since the block number is always zero for these chains.

redis-server/cache.js

Line 270 in ff5a6bf

await putRedisItem(ids.lastCachedBlockNft, {

In this instance ids.lastCachedBlockNft @ redisPrefixes.mainnetsidechainNft is incorrectly being set when each of these chains are processed.

[avaer]

The question is, do we need to cache polygon network at all? Is that ever needed?

[soulofmischief]

The question is, do we need to cache polygon network at all? Is that ever needed?

I would consider that a case of premature optimization, I'll look into why this method is being called on polygon.

[avaer]

My best guess is I had plans to do separate caching but there is no actual polygon caching needed right now.

The mainnetsidechain cache gets what it needs by querying polygon network, but I don't know what the purpose of doing a caching pass over polygon would be. I don't even think the signing server needs that.