Skip to content

Comments

Added EKS Infrastructure#9

Open
utf94 wants to merge 38 commits intowebaverse:masterfrom
utf94:master
Open

Added EKS Infrastructure#9
utf94 wants to merge 38 commits intowebaverse:masterfrom
utf94:master

Conversation

@utf94
Copy link
Contributor

@utf94 utf94 commented Nov 10, 2021

  1. EKS infrastructure is added.
  2. Dockerise the entire application
  3. Added build configuration
  4. Added Load balancer

@utf94
Copy link
Contributor Author

utf94 commented Nov 10, 2021

The PR is still in progress. Different GPU machines will be tested and the best results will be shared with @avaer and on approval, those build commands will be added.

Current buildspec points towards personal AWS of Kaneki.ken which will be updated once the machine spec is finalised

@utf94
Copy link
Contributor Author

utf94 commented Nov 22, 2021

@utf94 utf94 requested a review from avaer November 22, 2021 01:30
@utf94 utf94 changed the title [WIP] Added EKS Infrastructure Added EKS Infrastructure Nov 22, 2021
@avaer
Copy link
Contributor

avaer commented Nov 25, 2021

$ time curl 'https://preview.webaverse.com/?url=https://webaverse.github.io/assets/male.vrm&ext=vrm&type=png&width=200px&height=100px'
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

real    0m4.234s
user    0m0.000s
sys     0m0.016s

@avaer
Copy link
Contributor

avaer commented Nov 25, 2021

The current time is about 5 seconds to render. Is there a comparison table of the performance of each instance type?

- curl --silent --location "https://github.com/weaveworks/eksctl/releases/download/v0.72.0/eksctl_Linux_amd64.tar.gz" | tar xz -C /tmp
- mv -v /tmp/eksctl /usr/local/bin
- chmod +x /usr/local/bin/eksctl
- AWS_ACCOUNT_ID=684910554524
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to not hardcode the account id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we will move these files to Cloud Formation and the account id will be dynamic then.

Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine.

@avaer
Copy link
Contributor

avaer commented Nov 25, 2021

I think we can merge this, but I'd like to understand the different GPU options, and see if we can get the render time cut in half to about 2s as stated.

@utf94
Copy link
Contributor Author

utf94 commented Nov 25, 2021

@avaer Actually the time which is getting taken is in the downloading of the asset. If we host the asset files in S3 or in a CDN we will get rid of 1.5 seconds easily. Right now the GPU consumption is very less. In order to further check and refine it. I will add logs throughout the preview and screenshot system to know which part takes what time and also will play with the flags of the puppeteer if all go in vain then we can test more GPUs as testing GPU comes with a high cost since AWS has limited GPU to P3.2Xlarge machines (at minimum)

@ahadshams
Copy link

@rob-webaverse can you also confirm the impact on infra cost after this?

@rob-webaverse
Copy link
Contributor

@rob-webaverse can you also confirm the impact on infra cost after this?

It's adding about $4200/month right now, so more than +100% previous costs.

@avaer
Copy link
Contributor

avaer commented Nov 27, 2021

If we host the asset files in S3 or in a CDN we will get rid of 1.5 seconds easily.

How? The first hit is the common case and it seems uploading to CDN would make it even slower by adding that layer.

Also I don't fully understand the timing. This file is 8KB and fits in 6 packets. I doubt 6 packets takes1.5 seconds, unless AWS routing is really that slow.

@avaer
Copy link
Contributor

avaer commented Nov 27, 2021

Btw I think optimizing this is pretty important for the user experience. Seconds shaved off will make for a much better gamefeel.

@utf94
Copy link
Contributor Author

utf94 commented Nov 27, 2021

@avaer we are having a render time of 1.2 seconds. While the asset download time is 2.1 seconds what are your suggestions on this?

That makes the request span between 4->5 seconds in total.

image

image

@avaer
Copy link
Contributor

avaer commented Nov 27, 2021

Which part of the download is slow? That seems excessive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants