[TASK] Ensure some spacing below translation mode icons#17
Merged
Conversation
The translation model used in the PageLayoutModule get the available translation modes over an AJAX request and rendering the mode rows in JavaScript. To prepare the reduction of the mode description in `EXT:deepltranslate_core` this change now adds ```html style="margin-bottom: 20px;" ``` to the left mode select column for each mode to ensure some spacing if the description text is to small. Used command(s): ```shell Build/Scripts/runTests.sh -t 12 \ -s buildCoreOverrideJavaScriptFiles \ && Build/Scripts/runTests.sh -t 13 \ -s buildCoreOverrideJavaScriptFiles ``` [1] web-vision/deepltranslate-core#512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translation model used in the PageLayoutModule get
the available translation modes over an AJAX request
and rendering the mode rows in JavaScript.
To prepare the reduction of the mode description in
EXT:deepltranslate_corethis change now addsto the left mode select column for each mode to ensure
some spacing if the description text is to small.
Used command(s):
Build/Scripts/runTests.sh -t 12 \ -s buildCoreOverrideJavaScriptFiles \ && Build/Scripts/runTests.sh -t 13 \ -s buildCoreOverrideJavaScriptFiles[1] web-vision/deepltranslate-core#512