Create WebDX feature for app migration#3911
Create WebDX feature for app migration#3911Dp-Goog wants to merge 4 commits intoweb-platform-dx:mainfrom
Conversation
github-actions
bot
added
the
feature definition
features/app-migration.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: App Migration | |||
| description: Web Application Origin Migration allows a web application to indicate to the user agent that it moved from one origin to another (within the same site). This then enables the user agent to migrate an installed web application while preserving the user's installation and potentially their settings. | |||
There was a problem hiding this comment.
Proposal to use the entry points of the feature in the description. I'm not sure what gets preserved exactly, so the end of the description might need to be improved:
| description: Web Application Origin Migration allows a web application to indicate to the user agent that it moved from one origin to another (within the same site). This then enables the user agent to migrate an installed web application while preserving the user's installation and potentially their settings. | |
| description: The `migrate_to` and `migrate_from` web app manifest members inform the user agent that the web app moved from one origin to another within the same site. The user agent can then update the app's local installation without losing user settings. |
There was a problem hiding this comment.
Possibly helpful here, here's an edit of my version from #3859 (comment):
| description: Web Application Origin Migration allows a web application to indicate to the user agent that it moved from one origin to another (within the same site). This then enables the user agent to migrate an installed web application while preserving the user's installation and potentially their settings. | |
| description: The `migrate_to` and `migrate_from` web app manifest members move an installed app from one origin within the same site to another. They preserve the installation and user settings. |
There was a problem hiding this comment.
I like it. I would maybe just move the "same site" thing to the end of the sentence, like so:
| description: Web Application Origin Migration allows a web application to indicate to the user agent that it moved from one origin to another (within the same site). This then enables the user agent to migrate an installed web application while preserving the user's installation and potentially their settings. | |
| description: The `migrate_to` and `migrate_from` web app manifest members move an installed app from one origin to another, within the same site. They preserve the installation and user settings. |
There was a problem hiding this comment.
I went with the following:
The `migrate_to` and `migrate_from` web app manifest members move an installed app from one origin to another, within the same site. They preserve the user's installation settings and OS integration.
How does that sound?
features/app-migration.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: App Migration | |||
There was a problem hiding this comment.
| name: App Migration | |
| name: Application origin migration |
There was a problem hiding this comment.
@captainbrosset We should probably find some consistency for PWA feature names. For manifest features, we've got names in the form of:
- Web app bars (Web app manifest localization)
- Application bazzes (Application shortcuts)
- Quuxes (Share targets)
I'm partial to the latter two, but I don't feel strongly between them.
The IDs are more consistent, with app-, so we probably shouldn't try to change the ID here.
There was a problem hiding this comment.
I would probably want to keep the "Web app" or "Application" prefix. I quite like "Web app" because it's very closely related to PWAs. Searching for "Web app" on Google returns a lot of PWA-related results. And the manifest spec also uses the term "Web app" (or, rather, it uses "Web application", but not "Application" alone).
So maybe:
- Web app manifest location
- Web app shortcuts
- Web app share targets
- Web app origin migration
What do you think?
There was a problem hiding this comment.
I like the Web app prefix to the features, will update the entry to match that name.
features/app-migration.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: App Migration | |||
There was a problem hiding this comment.
@captainbrosset We should probably find some consistency for PWA feature names. For manifest features, we've got names in the form of:
- Web app bars (Web app manifest localization)
- Application bazzes (Application shortcuts)
- Quuxes (Share targets)
I'm partial to the latter two, but I don't feel strongly between them.
The IDs are more consistent, with app-, so we probably shouldn't try to change the ID here.
features/app-migration.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: App Migration | |||
| description: Web Application Origin Migration allows a web application to indicate to the user agent that it moved from one origin to another (within the same site). This then enables the user agent to migrate an installed web application while preserving the user's installation and potentially their settings. | |||
There was a problem hiding this comment.
Possibly helpful here, here's an edit of my version from #3859 (comment):
| description: Web Application Origin Migration allows a web application to indicate to the user agent that it moved from one origin to another (within the same site). This then enables the user agent to migrate an installed web application while preserving the user's installation and potentially their settings. | |
| description: The `migrate_to` and `migrate_from` web app manifest members move an installed app from one origin within the same site to another. They preserve the installation and user settings. |
| - manifests.webapp.migrate_from | ||
| - manifests.webapp.migrate_to |
There was a problem hiding this comment.
These will error until the next BCD release and upgrade here. If we get this into mergeable shape before that happens, I'll take responsibility for syncing up the dist file and merging then.
There was a problem hiding this comment.
SGTM! I updated the comments and the name as per the feedback here, PTAL and lmk if this is in a mergable state. Happy to offload this on to you for later!
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
This is looking great. Can you please run npm run dist features/app-migration.yml to generate the dist file? Once done, this should be mergeable.
features/app-migration.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: Web app origin migration | |||
| description: The `migrate_to` and `migrate_from` web app manifest members move an installed app from one origin to another, within the same site. They preserve the user's installation settings and OS integration. | |||
There was a problem hiding this comment.
"OS integration" sounds a bit vague to me, but I'm not going to block approving the review based on this. We can always improve this later if we have a better idea.
There was a problem hiding this comment.
On a narrower basis, I think "OS" is worth revising now. Our guidelines suggest that we might avoid the undefined abbreviation with "device" instead.
That said, I agree with Patrick on the vagueness front. What does "OS integration" mean? Perhaps the answer to that question can take its place.
There was a problem hiding this comment.
By OS settings, I was mostly talking about things like shortcuts and run on OS login states for the installed PWA. Does the current statement sound better?
Sadly I can't do this yet @captainbrosset , because the BCD keys for it hasn't been released. More context about that in here: #3859 (comment) |
3 participants
This helps solve #3859.
Fixes #3859