Conversation
github-actions
bot
added
the
feature definition
ddbeck
force-pushed
the
regress-clear-site-data
branch
from
7a50f3a to
f886216
Compare
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
Approved, modulo two comments. But no need for a re-review.
features/clear-site-data.yml
Outdated
| # Freezing this status until upstream can be trusted | ||
| # - https://github.com/web-platform-dx/web-features/pull/3881#discussion_r2983196809 | ||
| # TODO: https://github.com/web-platform-dx/web-features/issues/1971 | ||
| # YYYY-MM-DD — low → false — A bug in Chrome prevents `Clear-Site-Data` from taking full effect until after a hard refresh. |
There was a problem hiding this comment.
Is your plan to replace YYYY-MM-DD with the date when the PR merges? If so, this comment serves as a reminder to do this.
features/clear-site-data.yml
Outdated
| firefox_android: "63" | ||
| safari: "17" | ||
| safari_ios: "17" | ||
| compute_from: http.headers.Clear-Site-Data.wildcard |
There was a problem hiding this comment.
I was expecting http.headers.Clear-Site-Data to be partial itself, and therefore this compute_from field to be unneeded.
Maybe add a comment line saying why we've chosen the wildcard key top hold off the feature.
There was a problem hiding this comment.
Good catch. I've updated this with a comment and to use a wider set of keys in the compute_from. Really, the trouble here is that cache is busted and wildcard (*) invokes cache. So I updated the list to match the feature description fully.
2 participants
Chrome has some serious bugs in clearing the cache; this should regress to limited availability. See mdn/browser-compat-data#29333.