Use file extensions in web-features package type declarations#3885
Open
ddbeck wants to merge 2 commits intoweb-platform-dx:mainfrom
Open
Use file extensions in web-features package type declarations#3885ddbeck wants to merge 2 commits intoweb-platform-dx:mainfrom
ddbeck wants to merge 2 commits intoweb-platform-dx:mainfrom
Conversation
ddbeck
added
minor version required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #3878 and a companion to #3879.
This PR narrowly fixes the problem reported by @caugner in #3878 and updates the
tsconfig.jsonforweb-features. Claas's PR differs in that it applies the fix to the entire project, which I think is a good idea but slightly odd in not actually changing the config for the package that is the problem.Incidentally, by using a file extension, it caused eslint to check the built files. There's no need to check files we're not actually authoring, so I've ignored those files. In another bit of yak shaving, I had to upgrade to eslint's current config format, thus the oversize diff.