Skip to content

@typescript-eslint/no-deprecated #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScriptedAlchemy wants to merge 21 commits into
base: main
Choose a base branch
from
Open

@typescript-eslint/no-deprecated #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b6364c5
feat(typescript): add no-deprecated rule
ScriptedAlchemy Mar 3, 2026
f60c6fd
fix: harden no-deprecated parity behavior
ScriptedAlchemy Mar 3, 2026
17cb705
test: cover no-deprecated allow from:file import behavior
ScriptedAlchemy Mar 4, 2026
3c108ce
fix: resolve no-deprecated ci regressions
ScriptedAlchemy Mar 4, 2026
1dcf062
fix: satisfy spell check in no-deprecated rule
ScriptedAlchemy Mar 4, 2026
d8c76d5
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 4, 2026
f198f8e
Merge remote-tracking branch 'origin/main' into codex/ts-eslint-no-de…
ScriptedAlchemy Mar 5, 2026
aca8f1a
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 11, 2026
76761af
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 11, 2026
82c1a55
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 12, 2026
740cf1c
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 12, 2026
9787800
Merge remote-tracking branch 'origin/main' into codex/ts-eslint-no-de…
ScriptedAlchemy Mar 12, 2026
ca7c508
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 12, 2026
21db900
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 12, 2026
c9aab7c
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 16, 2026
35fafba
fix: tighten no-deprecated from-file allow matching
ScriptedAlchemy Mar 16, 2026
9004e3e
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 17, 2026
cd4128b
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 19, 2026
084ca08
Merge branch 'main' into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy Mar 19, 2026
ad15bbe
Merge origin/main into codex/ts-eslint-no-deprecated-92ca
ScriptedAlchemy May 25, 2026
b1a05e7
fix: harden no-deprecated parity
ScriptedAlchemy May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions cmd/rslint/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,20 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
sourceFiles[filePath] = sourceFile
sourceFilesLock.Unlock()

if len(req.RuleOptions) == 0 {
Copy link
Copy Markdown
Contributor

@fansenze fansenze May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated infra changes, with an empty PR description:

  • This len(req.RuleOptions) == 0 branch changes global behavior (runs config-enabled rules instead of nothing when no options are passed).
  • RuleCount (L291) changes from "configured" to "executed".
  • RequiresTypeInfo (L259): by code reading this appears to be a no-op on the IPC path (no TypeInfoFiles is passed and IPC never calls FilterNonTypeAwareRules) — if it's actually needed, add a test; if not, drop it.

Please split infra changes into a separate PR and document them.

rules, _ := rslintconfig.GlobalRuleRegistry.GetEnabledRules(rslintConfig, sourceFile.FileName(), configDirectory, false)
return rules
}

var settings map[string]interface{}
if merged := rslintConfig.GetConfigForFile(sourceFile.FileName(), configDirectory); merged != nil && len(merged.Settings) > 0 {
settings = rslintconfig.CloneSettings(merged.Settings)
}

return utils.Map(rulesWithOptions, func(r RuleWithOption) linter.ConfiguredRule {

return linter.ConfiguredRule{
Name: r.rule.Name,
Settings: settings,
Name: r.rule.Name,
Settings: settings,
RequiresTypeInfo: r.rule.RequiresTypeInfo,
Run: func(ctx rule.RuleContext) rule.RuleListeners {
return r.rule.Run(ctx, r.option)
},
Expand Down Expand Up @@ -284,7 +288,7 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
Diagnostics: diagnostics,
ErrorCount: errorsCount,
FileCount: int(lintResult.LintedFileCount),
RuleCount: len(rulesWithOptions),
RuleCount: len(lintResult.ExecutedRules),
}
// Only include encoded source files if requested
if req.IncludeEncodedSourceFiles {
Expand Down
2 changes: 2 additions & 0 deletions internal/plugins/typescript/all.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_base_to_string"
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_confusing_non_null_assertion"
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_confusing_void_expression"
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_deprecated"
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_dupe_class_members"
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_duplicate_enum_values"
"github.com/web-infra-dev/rslint/internal/plugins/typescript/rules/no_duplicate_type_constituents"
Expand Down Expand Up @@ -165,6 +166,7 @@ func GetAllRules() []rule.Rule {
no_base_to_string.NoBaseToStringRule,
no_confusing_non_null_assertion.NoConfusingNonNullAssertionRule,
no_confusing_void_expression.NoConfusingVoidExpressionRule,
no_deprecated.NoDeprecatedRule,
no_dupe_class_members.NoDupeClassMembersRule,
no_duplicate_enum_values.NoDuplicateEnumValuesRule,
no_duplicate_type_constituents.NoDuplicateTypeConstituentsRule,
Expand Down
Loading
Loading