Skip to content

Fix the Gutenberg edit icons and remove default border from images#183

Open
nelsonamaya82 wants to merge 1 commit intomasterfrom
fix-admin-gutenblocks-icons
Open

Fix the Gutenberg edit icons and remove default border from images#183
nelsonamaya82 wants to merge 1 commit intomasterfrom
fix-admin-gutenblocks-icons

Conversation

@nelsonamaya82
Copy link
Copy Markdown
Contributor

This SVG style is breaking the Guten blocks edit buttons. I think the SVG size should be limited by the parent element instead. Also there are some cases where we need to use the same SVG in different sizes, even bigger than the 100%.

Also the Tailwind utilities styles were affecting the images in the editor by adding a black border to them. I think images shouldn’t have a border style by default.

@adamf321
Copy link
Copy Markdown
Member

@nelsonamaya82 does GCC have the same problems?

@nelsonamaya82
Copy link
Copy Markdown
Contributor Author

@nelsonamaya82 does GCC have the same problems?

Yes @adamf321 I just checked it and it does.

In this case, the More Options button is overlapping the Switch to edit/preview button.
image

And in this case, it's adding a black solid border to all the images:
image

@adamf321
Copy link
Copy Markdown
Member

Got it. But shouldn't SVGs have some sort of reset style like IMGs do? I'm pretty sure this change would break GCC in some places.

@nelsonamaya82
Copy link
Copy Markdown
Contributor Author

@adamf321 I had not seen any reset in the CSS resetters for SVGs, just for img, and as SVGs can have any size, we should constraint their size with the parent element (or with the SVG code itself).

@adamf321
Copy link
Copy Markdown
Member

I thought the previous code did this, it retrains the SVG size to the container. Without the max width/height it will overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants