Zach - Submission - cli-todo-sql#100
Open
zachariah-chow wants to merge 2 commits intowdi-sg:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting. Comfort Level (1-5):
Completeness Level (1-5): 3, left quite a few of the furthers incomplete
How many hours did you spend on this assignment? 1+?
What part did you spend the most time on? Not alot of actual time spent as most of the conditional logic had been reused from the previous cli-todo assignment. Most of my time was spent on reading up on SQL syntax re: data-types / constraints.
Does the assignment run without errors? If the assignment has errors, what are they? Yes, mostly.
Describe one part of the code or choose one line you would improve upon. What would you improve? More input validation. Use narrower data-type constraints for the database perhaps (right now I'm still using the JavaScript Date object, and inserting the returned string into my date column which takes a VARCHAR data-type. Have not figured out how to get Timezone specific Date/Time from Postgres using a Date data-type)
What did you think of this deliverable? Any other comments?
Good SQL practice, more of which I require very much.