fix: float infobox beside article body (Wikipedia-style)#27
Open
EthanThatOneKid wants to merge 2 commits into
Open
fix: float infobox beside article body (Wikipedia-style)#27EthanThatOneKid wants to merge 2 commits into
EthanThatOneKid wants to merge 2 commits into
Conversation
Split the page title from the body, wrap the infobox and content in a flow-root container, and float the infobox right with aside semantics. Remove page-meta styling from the infobox so footer sections stay full width.
EthanThatOneKid
force-pushed
the
fix/infobox-wikipedia-layout
branch
from
42b9837 to
5f505ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26. Typed pages now render the frontmatter infobox in a Wikipedia-style layout: full-width title, infobox floated top-right beside the body, footer sections unchanged below the article.
Changes
wiki-article-titleandwiki-article-bodydisplay: flow-rootbody container<aside class="infobox">withoutpage-metafooter stylesTest plan
pytest tests/test_site.pywiki -c docs/wiki.json serve --watch→ open/wiki/farzapedia/and confirm infobox is top-right beside intro textservesession was cached