Open
Conversation
ftshijt
reviewed
Dec 2, 2024
Contributor
ftshijt
left a comment
ftshijt
left a comment
There was a problem hiding this comment.
Many thanks for the contribution. It is so cool to have the setup in versa. I left a few minor comments but in general, it looks great to me
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ftshijt
reviewed
Dec 3, 2024
Contributor
ftshijt
left a comment
ftshijt
left a comment
There was a problem hiding this comment.
LGTM! Let's proceed to the following stages.
|
@ftshijt @darius522 nice effort 👍 Did you have a look over at Ashvala/AQUA-Tk#5 which is an attempt to make a python version of |
Contributor
|
Interesting, if we can have pythonic version that would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ftshijt Getting this 2f model code up and running is quite a ride, mainly because of the matlab dependencies. I have added a README going over the considerations needed to have it working locally (assuming matlab exists on the user's machine). Among the sea of files related to PEAQ features extraction, the one that actually matters is
versa/sequence_metrics/2f_model/compute_2f_metric.py. Please take a look and let me know if this format works for you. We'll then integrate the metrics intoversa/scorer_shared.pyonce this is out of the way!