Repository navigation
fix(build): activate Cargo binary and receipt as a recoverable pair - #1087
Open
hiyouwhatsapp wants to merge 1 commit into
Open
hiyouwhatsapp wants to merge 1 commit into
hiyouwhatsapp wants to merge 1 commit into
Conversation
…ansaction Stage and validate both outputs before replacing either, use the existing backup-aware replacement utility, and preserve the executable mode of the compiled binary Cover receipt conflicts, successful activation, rollback, retained recovery backups and missing previous receipts Signed-off-by: hiyouwhatsapp <89997383+hiyouwhatsapp@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1079
The build-cargo helper previously replaced the compiler binary before writing its build.json receipt, so a receipt failure could discard the previous successful compiler
I now prepare and validate both destinations and stage the binary and serialized receipt before any replacement
Both files are activated through the existing backup-aware multi-file replacement transaction, restoring the previous output pair on failure or retaining recovery backups when restoration cannot complete
A conflicting receipt directory or symlink is rejected before touching the previous output, and the newly staged compiler retains its executable permissions
Added five focused regression tests for successful matching binary/receipt activation, a conflicting receipt directory, receipt activation rollback, restoration failure with retained backups, and a previously absent receipt
Cargo invocation, receipt identity validation and Meson orchestration are unchanged
The Rust suite has not been run locally, so CI still needs to verify the patch