Repository navigation
fix(nightly): reconcile obsolete staging assets before verification - #1086
Open
hiyouwhatsapp wants to merge 1 commit into
Open
hiyouwhatsapp wants to merge 1 commit into
hiyouwhatsapp wants to merge 1 commit into
Conversation
Retain preflight checks for conflicting current-generation assets and only delete obsolete assets from the private staging draft after upload Exercise partial generations, cleanup failures, retries and conflicting assets with globally unique mock asset identities Signed-off-by: hiyouwhatsapp <89997383+hiyouwhatsapp@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1078
A previous partial Nightly upload can leave obsolete assets in the private staging draft, causing exact remote verification to fail before the existing cleanup loop can run
I moved obsolete staging-asset deletion before exact-set verification, while retaining the preflight conflict checks for current-generation filenames and all existing checksum, size and publication-identity gates
The active public Nightly is untouched until the new private draft passes exact verification and the existing promotion checks
Updated the mock GitHub API to use globally unique asset IDs so staging cleanup cannot accidentally alias public-release assets
Added regression tests for a partial older staging generation, successful newer promotion and repeat attempts, cleanup failure with retry, conflicting current-generation assets and interrupted uploads
The expected 29-asset set and nine package targets remain unchanged
The Rust test suite hasn't been run locally and CI still needs to verify the change