Use the public claude platform plugin.#12879
Conversation
1bf5610 to
de650a3
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR moves the Claude platform plugin marketplace from the internal repository to the public warpdotdev/claude-code-warp repository and lowers the asserted minimum platform plugin version.
Concerns
- Removing
PLATFORM_MARKETPLACE_REPObreaks the remaining unchangedupdate_platform_plugincall site, so the Rust code will not compile until that call site is updated or the constant is kept. - No approved or repository spec context was available, so there were no spec-alignment commitments to validate.
Verdict
Found: 1 critical, 0 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| const PLATFORM_PLUGIN_KEY: &str = "oz-harness-support@claude-code-warp"; | ||
| // Note: we will eventually publish this to the same marketplace repo, but are using the internal one as we build out multi-harness. | ||
| const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal"; |
There was a problem hiding this comment.
🚨 [CRITICAL] Deleting this constant leaves the unchanged update_platform_plugin method referencing PLATFORM_MARKETPLACE_REPO, so the crate will fail to compile; update that call site to MARKETPLACE_REPO too or keep the constant.
| // Keep in sync with the oz-harness-support plugin version in warpdotdev/claude-code-warp-internal. | ||
| const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "1.1.3"; | ||
| // Keep in sync with the oz-harness-support plugin version in warpdotdev/claude-code-warp. | ||
| const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "1.1.2"; |
There was a problem hiding this comment.
Is this something we should have some sort of automated test for?
There was a problem hiding this comment.
Yeah 100%. It shouldn't be hard to - we should check that this value matches:
https://github.com/warpdotdev/claude-code-warp/blob/58c823da195346a7e6645fd2d9484d0e38db6bc2/.claude-plugin/marketplace.json#L21
and
https://github.com/warpdotdev/claude-code-warp/blob/58c823da195346a7e6645fd2d9484d0e38db6bc2/plugins/oz-harness-support/.claude-plugin/plugin.json#L4
(same for the non-platform plugin)
|
|
||
| const PLATFORM_PLUGIN_KEY: &str = "oz-harness-support@claude-code-warp"; | ||
| // Note: we will eventually publish this to the same marketplace repo, but are using the internal one as we build out multi-harness. | ||
| const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal"; |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
|
1 similar comment
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
|
c7b4c82 to
3aac552
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
|
3aac552 to
8f2d6ee
Compare
9f62f73 to
e2c4cdc
Compare
Description
After we update
claude-code-warpto include the platform plugin for multi-harness runs, we need to update the driver to pull that version of the plugin in: warpdotdev/claude-code-warp#69.I also noticed that the minimum plugin version asserted in this repo was too high given the version we have set in
claude-code-warp-internal, meaning that the platform will always fail to start the driver since it tries to update to a version that doesn't exist.Testing
I will test with
oz-localonce the other PR lands.