Skip to content

Use the public claude platform plugin.#12879

Merged
liliwilson merged 7 commits into
masterfrom
lili/use-public-claude-plugin
Jun 22, 2026
Merged

Use the public claude platform plugin.#12879
liliwilson merged 7 commits into
masterfrom
lili/use-public-claude-plugin

Conversation

@liliwilson

Copy link
Copy Markdown
Contributor

Description

After we update claude-code-warp to include the platform plugin for multi-harness runs, we need to update the driver to pull that version of the plugin in: warpdotdev/claude-code-warp#69.

I also noticed that the minimum plugin version asserted in this repo was too high given the version we have set in claude-code-warp-internal, meaning that the platform will always fail to start the driver since it tries to update to a version that doesn't exist.

Testing

I will test with oz-local once the other PR lands.

@cla-bot cla-bot Bot added the cla-signed label Jun 21, 2026
@liliwilson liliwilson force-pushed the lili/use-public-claude-plugin branch from 1bf5610 to de650a3 Compare June 21, 2026 15:54
@liliwilson liliwilson marked this pull request as ready for review June 21, 2026 15:59
@oz-for-oss

oz-for-oss Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

@liliwilson

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR moves the Claude platform plugin marketplace from the internal repository to the public warpdotdev/claude-code-warp repository and lowers the asserted minimum platform plugin version.

Concerns

  • Removing PLATFORM_MARKETPLACE_REPO breaks the remaining unchanged update_platform_plugin call site, so the Rust code will not compile until that call site is updated or the constant is kept.
  • No approved or repository spec context was available, so there were no spec-alignment commitments to validate.

Verdict

Found: 1 critical, 0 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz


const PLATFORM_PLUGIN_KEY: &str = "oz-harness-support@claude-code-warp";
// Note: we will eventually publish this to the same marketplace repo, but are using the internal one as we build out multi-harness.
const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 [CRITICAL] Deleting this constant leaves the unchanged update_platform_plugin method referencing PLATFORM_MARKETPLACE_REPO, so the crate will fail to compile; update that call site to MARKETPLACE_REPO too or keep the constant.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems important

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

// Keep in sync with the oz-harness-support plugin version in warpdotdev/claude-code-warp-internal.
const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "1.1.3";
// Keep in sync with the oz-harness-support plugin version in warpdotdev/claude-code-warp.
const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "1.1.2";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we should have some sort of automated test for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


const PLATFORM_PLUGIN_KEY: &str = "oz-harness-support@claude-code-warp";
// Note: we will eventually publish this to the same marketplace repo, but are using the internal one as we build out multi-harness.
const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems important

@cla-bot

cla-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot Bot removed the cla-signed label Jun 21, 2026
@cla-bot

cla-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot

cla-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@liliwilson liliwilson force-pushed the lili/use-public-claude-plugin branch from c7b4c82 to 3aac552 Compare June 21, 2026 22:41
@cla-bot

cla-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@liliwilson liliwilson force-pushed the lili/use-public-claude-plugin branch from 3aac552 to 8f2d6ee Compare June 21, 2026 22:43
@cla-bot cla-bot Bot added the cla-signed label Jun 21, 2026
@liliwilson liliwilson force-pushed the lili/use-public-claude-plugin branch from 9f62f73 to e2c4cdc Compare June 22, 2026 15:16
@liliwilson liliwilson merged commit 71d95da into master Jun 22, 2026
25 checks passed
@liliwilson liliwilson deleted the lili/use-public-claude-plugin branch June 22, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants