Surface PR author trust in the review prompt#483
Draft
vkodithala wants to merge 1 commit into
Draft
Conversation
The review agent is told not to call GitHub, so it has no way to tell whether a PR author is a Warp org member or an external contributor. This adds an `Author` line to the PR description the agent already reads (`pr_description.txt`), tagging the author with their GitHub association and a `trust=TRUSTED|UNVERIFIED` label derived from `ORG_MEMBER_ASSOCIATIONS`. This lets the warp `review-pr-local` skill scope its visual-evidence requirement to external contributors only (companion change in warp). Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Threads an explicit author trust signal into the PR review prompt so the cloud review agent can tell whether a PR was authored by a Warp organization member or an external contributor.
The review agent is explicitly instructed not to call GitHub, so today it has no membership signal at all. This adds an
Authorline to the PR description the agent already reads (pr_description.txt):trustisTRUSTEDwhen the GitHubauthor_associationis inORG_MEMBER_ASSOCIATIONS(MEMBER/OWNER/COLLABORATOR), andUNVERIFIEDotherwise.Why
In #feedback-app, internal contributors ("warpers") have been getting
Request changeson nearly every PR because the warpreview-pr-localskill requires visual evidence (screenshots/recordings) for user-facing changes. The agreed fix is to keep that requirement for external contributors but drop it for org members. The skill had no way to distinguish the two — this change provides the signal. The companion skill change lives inwarpdotdev/warp.Testing
python -m pytest tests— 438 passed, 67 subtests passed.Authortrust line rendersTRUSTEDforMEMBERauthors andUNVERIFIEDfor external (CONTRIBUTOR) authors.Conversation: https://staging.warp.dev/conversation/484fda0c-894d-40f0-b9af-e9688acfb6fa
Run: https://oz.staging.warp.dev/runs/019ecd58-d020-7d93-9008-d5b4cb9fc0b2
This PR was generated with Oz.