Repository navigation
Prepare for the community directory as GitHub Enterprise Sync - #1
Merged
Merged
Conversation
Rename the plugin to "GitHub Enterprise Sync" (id github-enterprise-sync): plugin ids may not contain "obsidian", and "GitHub Sync" is already taken. The description now leads with what sets it apart: GitHub Enterprise Server, the REST API instead of a Git binary, OAuth device flow, mobile. Review fixes: - Type every GitHub API and OAuth response; remove console.log calls; move the sign-in modal's inline styles into styles.css. - Refuse the vault's actual config folder (vault.configDir) rather than a hardcoded .obsidian, so a renamed config folder can't be overwritten from the repo. - Send Cache-Control: no-cache on API reads. Obsidian's requestUrl honoured GitHub's max-age=60, so a sync within a minute of the last one could see a stale branch head and miss commits from another device. - Prefer the Vault API for note files (modify/create/readBinary, and FileManager.trashFile for deletes); fall back to the adapter for hidden paths and when the index lags the disk. Listing stays on the filesystem, where index lag can't masquerade as a local deletion. - Build the settings tab from getSettingDefinitions(), so it's searchable; minAppVersion is now 1.13.0. - README: network use and privacy disclosure, screenshots. Testing: - tests/app/ runs the built plugin inside the real Obsidian desktop app, on desktop and in phone emulation, over the DevTools protocol. - npm run screenshots regenerates docs/screenshots/ with identifying values redacted. - Obsidian's ESLint rules run via npm run lint. - The e2e config accepts environment variables and an E2E_TOKEN. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Unit tests and lint on every push and PR; the e2e suite and the in-Obsidian suite (macOS runner, latest Obsidian release) when the E2E_TOKEN secret is available, skipping otherwise. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… dir Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A freshly installed Obsidian on the CI runner wasn't registered with Launch Services yet, so `open -a Obsidian` failed to find it. Launch by path, and register the app after installing it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
wandermyz
force-pushed
the
catalog-readiness
branch
from
October 18, 2026 07:15
ebe1ea5 to
6c11c02
Compare
The e2e and app suites run concurrently in CI against one test branch. A helper commit could read the head, then lose the ref update to the other suite's commit and fail with 422 "not a fast forward". Rebuild on the new head and retry; each run only touches its own folder. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
wandermyz
force-pushed
the
catalog-readiness
branch
from
October 18, 2026 07:19
6c11c02 to
b93800b
Compare
wandermyz
marked this pull request as ready for review
October 18, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness work for submitting to the Obsidian community directory.
github-enterprise-sync) — ids can't contain "obsidian" and "GitHub Sync" is taken.styles.css,vault.configDirguard, Vault API for note files, declarative settings (minAppVersion→ 1.13.0).Cache-Control: no-cache; Obsidian'srequestUrlwas serving cached branch heads for up to 60 s.Draft while CI is verified on GitHub.
🤖 Generated with Claude Code