Skip to content

fix(controller): Skip no-op infra resource updates, and use actual mysql server status#135

Draft
casey-coreweave wants to merge 3 commits intov2from
controller_skip_noop
Draft

fix(controller): Skip no-op infra resource updates, and use actual mysql server status#135
casey-coreweave wants to merge 3 commits intov2from
controller_skip_noop

Conversation

@casey-coreweave
Copy link

@casey-coreweave casey-coreweave commented Mar 9, 2026

  • Avoid no-op updates, by checking deep derivative equality and skipping resource action when there is nothing to do
  • Attempts to actually derive mysql server status

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 479d4754-a254-4c48-ae77-7ec36687a179

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch controller_skip_noop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@casey-coreweave casey-coreweave changed the title fix(controller): skip no-op infra resource updates fix(controller): Skip no-op infra resource updates Mar 9, 2026
@casey-coreweave casey-coreweave changed the title fix(controller): Skip no-op infra resource updates fix(controller): Skip no-op infra resource updates, and use actual mysql server status Mar 9, 2026
@casey-coreweave casey-coreweave marked this pull request as draft March 10, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant