fix: ONPREM-111 retention policy (purge) implementation#134
fix: ONPREM-111 retention policy (purge) implementation#134danielpanzella merged 9 commits intov2from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| func ReadState( | ||
| ctx context.Context, | ||
| client client.Client, | ||
| cl client.Client, |
There was a problem hiding this comment.
can we rename this to k8sClient instead of shortening to cl, I think this is done is several files
| const ( | ||
| WandbNameLabel = "apps.wandb.com/name" | ||
| WandbNamespaceLabel = "apps.wandb.com/namespace" | ||
| WandbModuleLabel = "apps.wandb.com/module" |
There was a problem hiding this comment.
As we discussed, lets rename module to component and use the full GK weightsandbiases.apps.wandb.com for the labels
tested
purgefor dev & small for wandb deletion and by wandb infraenabled: falseit has an opinionated view of labeling pvcs and other resources