Skip to content

fix: ONPREM-111 retention policy (purge) implementation#134

Merged
danielpanzella merged 9 commits intov2from
j7m4/clickhouse-retention
Mar 10, 2026
Merged

fix: ONPREM-111 retention policy (purge) implementation#134
danielpanzella merged 9 commits intov2from
j7m4/clickhouse-retention

Conversation

@j7m4
Copy link

@j7m4 j7m4 commented Mar 3, 2026

tested purge for dev & small for wandb deletion and by wandb infra enabled: false
it has an opinionated view of labeling pvcs and other resources

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f5f8ed9-592c-4690-b113-29dfe649d65a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch j7m4/clickhouse-retention

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

func ReadState(
ctx context.Context,
client client.Client,
cl client.Client,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this to k8sClient instead of shortening to cl, I think this is done is several files

const (
WandbNameLabel = "apps.wandb.com/name"
WandbNamespaceLabel = "apps.wandb.com/namespace"
WandbModuleLabel = "apps.wandb.com/module"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, lets rename module to component and use the full GK weightsandbiases.apps.wandb.com for the labels

@danielpanzella danielpanzella merged commit 9d70e71 into v2 Mar 10, 2026
5 checks passed
@danielpanzella danielpanzella deleted the j7m4/clickhouse-retention branch March 10, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants