GDrive File Scope implementation with file picker#51
Open
Hoffs wants to merge 4 commits intowalterpg:masterfrom
Open
GDrive File Scope implementation with file picker#51Hoffs wants to merge 4 commits intowalterpg:masterfrom
Hoffs wants to merge 4 commits intowalterpg:masterfrom
Conversation
Owner
|
Thanks for this. As discussed in #42, the proposed scheme faces significant challenges in a non-SAAS, open source platform project. But as you claim that it can be done, it should be seriously considered. When I get a chance I will look at the PR and I hope others interested in this will too. |
This was referenced Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #42 I finally got around trying to implement this. As per my testing everything more or less works and the file scope seems to work as expected, only giving files that were picked. Adding this bit to somewhere will print out only 1 or how many files were picked.
Some difficult parts:
I don't expect this to be merged, a lot of parts are quite rough around the edges, data flow is a bit incorrect IMO at some parts, but it's a good POC that it's not that hard to use file scope. This should have no issues working with any other apps as long as they don't completely delete the file and upload new one in gdrive.