Fix: http schema handling#1482
Open
KevinSJ wants to merge 1 commit intowallabag:masterfrom
Open
Conversation
This was broken when the host name was added.
Contributor
|
What do you mean with "handle http scheme"? I do not get what is fixed with this commit. |
Author
|
@Strubbl So there is an option in wallabag settings to handle http scheme, which essentially makes wallabag appear as a browser. The PR I mentioned break this functionality. |
Contributor
|
Thanks for explaining. I need to check if we still need this at all and/or if it is mandatory for sharing URLs to wallabag app. |
Author
|
I don't think it's mandatory, but it does make things a lot more convinient. If we no longer need this, we should delete the option from settings. |
Contributor
|
Which convenience? Convenience sounds like a reason to keep the setting and make it work again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fr.gaulupeau.apps.Poche.ui.HttpSchemeHandlerActivity is supposed to be able to handle any http or https url.
However, as part of the change in #1434, this functionality was broken, it is not no longer possible to set wallabag to handle http scheme even when the setting option is set to true.
Reverting the change fixes this issue.